public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Klaus Jensen <its@irrelevant.dk>,
	linux-nvme@lists.infradead.org
Subject: [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers
Date: Tue, 12 Apr 2022 08:11:26 +0200	[thread overview]
Message-ID: <20220412061126.244414-4-hch@lst.de> (raw)
In-Reply-To: <20220412061126.244414-1-hch@lst.de>

Qemu unconditionally reports a UUID, which depending on the qemu version
is either all-null (which is incorrect but harmless) or contains a single
bit set for all controllers.  In addition it can also optionally report
a eui64 which needs to be manually set.  Disable namespace identifiers
for Qemu controlles entirely even if in some cases they could be set
corretly through manual intervention.

Reported-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c386c91483505..b191e7dcf15ca 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3410,6 +3410,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_VDEVICE(INTEL, 0x5845),	/* Qemu emulated controller */
 		.driver_data = NVME_QUIRK_IDENTIFY_CNS |
 				NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+	{ PCI_VDEVICE(REDHAT, 0x0010),	/* Qemu emulated controller */
+		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x126f, 0x2263),	/* Silicon Motion unidentified */
 		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
 	{ PCI_DEVICE(0x1bb1, 0x0100),   /* Seagate Nytro Flash Storage */
-- 
2.30.2



  parent reply	other threads:[~2022-04-12  6:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  6:11 quirk broken namespace identifiers Christoph Hellwig
2022-04-12  6:11 ` [PATCH 1/3] nvme: add a quirk to disable " Christoph Hellwig
2022-04-12  6:56   ` Chaitanya Kulkarni
2022-04-12  7:01     ` Christoph Hellwig
2022-04-12 10:25   ` Sagi Grimberg
2022-04-12 14:16   ` Keith Busch
2022-04-12  6:11 ` [PATCH 2/3] nvme-pci: disable namespace identifiers for the MAXIO MAP1202 Christoph Hellwig
2022-04-12  6:57   ` Chaitanya Kulkarni
2022-04-12 10:25   ` Sagi Grimberg
2022-04-12  6:11 ` Christoph Hellwig [this message]
2022-04-12  6:33   ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Klaus Jensen
2022-04-12 11:45     ` Christoph Hellwig
2022-04-12 20:43       ` Klaus Jensen
2022-04-12 10:25   ` Sagi Grimberg
  -- strict thread matches above, loose matches on Subject: below --
2022-04-13  4:49 quirk broken namespace identifiers v2 Christoph Hellwig
2022-04-13  4:49 ` [PATCH 3/3] nvme-pci: disable namespace identifiers for Qemu controllers Christoph Hellwig
2022-04-13  7:34   ` Niklas Cassel
2022-04-13  8:40     ` Klaus Jensen
2022-04-13 15:34       ` Christoph Hellwig
2022-04-13 15:49         ` Klaus Jensen
2022-04-13 15:50           ` Christoph Hellwig
2022-04-13 20:08             ` Klaus Jensen
2022-04-13 20:38               ` Keith Busch
2022-04-14  4:19               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412061126.244414-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=its@irrelevant.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mcgrof@kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox