Re: [PATCH v2 6/6] nvme-apple: Add initial Apple SoC NVMe driver

hch
2022-04-20T04:35:00Z

On Tue, Apr 19, 2022 at 11:52:15AM +0200, Arnd Bergmann wrote:
> > I just checked again and 64-bit accesses seem to work fine.
> > I'll remove the lo_hi_* calls and this include.
>
> If you remove the #include, it is no longer possible to compile-test
> this on all 32-bit architectures, though that is probably fine as long
> as the Kconfig file has the right dependencies, like
>
> depends on ARCH_APPLE || (COMPILE_TEST && 64BIT)
>
> I'd prefer to keep the #include here, but I don't mind the dependency
> if Christoph prefers it that way.

So thre's really two steps here:

1) stop uing lo_hi_readq diretly which forces 32-bit access even on
64-bit platforms
2) stop using the io-64-nonatomic headers entirely

I definitively want 1) done if the hardware does not require it. Trying
to cater to 32-bit build tests on hardware that has no chance of ever
being used there by including the header seems a bit silly, but if
it makes folks happy I can live with it.

>
> Arnd
---end quoted text---