From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D35D8C433FE for ; Wed, 20 Apr 2022 07:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/2fcLWe0DFPQBlcvBarJQBBvjVD+POqvj0LoXF+RAaI=; b=Eyl79k73ldLf8I6EIOCaCdGVbS bnWPCsb/C4wq5d9dpmEHR0MEsJmW3fAA1kgO8xyj57vSH1Qivaa0jN1wmA0vASyOfM+6Rp2lCpm40 XcW4hRrODrTlsYw83kiyu8xTAxZ6HewwNmt3ZeNXwoXJ3JR9tJwhEdUatDIp8WWfCFjFnLcmZKBn4 +wvWQ4EUlq4OSRQUqjstMay4TyxCAiYtbV1+orySVor6AWw1x7sSrtj1J7hiRAiAG+NzG4jOc1ZFd x3md/efXwd/uTtLUe0aHmnYWqnhbE7pw14dq2y7qfThtk/lw/qO3mWNmHyL0dpq9J9vWXThUcgp9R Gx27NuwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh4tQ-007oJB-FH; Wed, 20 Apr 2022 07:36:52 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh4tN-007oGt-Q6 for linux-nvme@lists.infradead.org; Wed, 20 Apr 2022 07:36:51 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3D6CB68AFE; Wed, 20 Apr 2022 09:36:41 +0200 (CEST) Date: Wed, 20 Apr 2022 09:36:41 +0200 From: Christoph Hellwig To: Alan Adamson Cc: Christoph Hellwig , Luis Chamberlain , Klaus Jensen , Keith Busch , Sagi Grimberg , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Message-ID: <20220420073641.GA6859@lst.de> References: <20220224192845.1097602-1-hch@lst.de> <20220224192845.1097602-5-hch@lst.de> <20220408052907.GA31990@lst.de> <20220408161052.GA28661@lst.de> <20220411050533.GB13927@lst.de> <20220411055455.GA14480@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_003650_036457_61304378 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Apr 18, 2022 at 11:30:33PM +0000, Alan Adamson wrote: > I ran into an issue with blktests and my qemu setup when passthru is enabled. The passthru tests > do not complete. This was because the UUID for the passthru device is coming from the a device > from the same system since the fabric was setup as a loop and nvme_global_check_duplicate_ids() fails. > > This is probably not a valid real life configuration, but since blktests try to test fabrics on a single > system, we have this issue. > > I’ve hacked together a fix to manipulate Namespace Identifier’s to get the test to work. Is there a > why for blktests to hardcode the IDs for the passthru devices? Hmm. I suspect the best thing would be to optionally just clear the IDS entirely. Optionally as in maybe a fabrics connect argument, with it defaulting to true only for loop as that is per definition local.