[PATCH RFC 2/5] tls: build proto after context has been initialized

Chuck Lever
2022-04-18T16:49:49Z

From: Hannes Reinecke <hare@suse.de>

We have to build the proto ops only after the context has been
initialized, as otherwise we might crash when I/O is ongoing
during initialisation.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
net/tls/tls_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
index 7b2b0e7ffee4..7eca4d9a83c4 100644
--- a/net/tls/tls_main.c
+++ b/net/tls/tls_main.c
@@ -836,8 +836,6 @@ static int tls_init(struct sock *sk)
struct tls_context *ctx;
int rc = 0;

- tls_build_proto(sk);
-
#ifdef CONFIG_TLS_TOE
if (tls_toe_bypass(sk))
return 0;
@@ -862,6 +860,7 @@ static int tls_init(struct sock *sk)

ctx->tx_conf = TLS_BASE;
ctx->rx_conf = TLS_BASE;
+ tls_build_proto(sk);
update_sk_prot(sk, ctx);
out:
write_unlock_bh(&sk->sk_callback_lock);