Re: [PATCH RFC 4/5] net/tls: Add support for PF_TLSH (a TLS handshake listener)

Jakub Kicinski
2022-04-26T14:55:16Z

On Tue, 26 Apr 2022 11:43:37 +0200 Hannes Reinecke wrote:
> > Create the socket in user space, do all the handshakes you need there
> > and then pass it to the kernel. This is how NBD + TLS works. Scales
> > better and requires much less kernel code.
> >
> But we can't, as the existing mechanisms (at least for NVMe) creates the
> socket in-kernel.
> Having to create the socket in userspace would require a completely new
> interface for nvme and will not be backwards compatible.
> Not to mention having to rework the nvme driver to accept sockets from
> userspace instead of creating them internally.
>
> With this approach we can keep existing infrastructure, and can get a
> common implementation for either transport.

You add 1.5kLoC and require running a user space agent, surely you're
adding new interfaces and are not backward-compatible already.

I don't understand your argument, maybe you could rephrase / dumb it
down for me?