Re: [PATCH v4 00/10] Add Copy offload support

Damien Le Moal
2022-04-27T12:49:26Z

On 4/26/22 19:12, Nitesh Shetty wrote:
> The patch series covers the points discussed in November 2021 virtual call
> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
> We have covered the Initial agreed requirements in this patchset.
> Patchset borrows Mikulas's token based approach for 2 bdev
> implementation.
>
> Overall series supports –
>
> 1. Driver
> - NVMe Copy command (single NS), including support in nvme-target (for
> block and file backend)
>
> 2. Block layer
> - Block-generic copy (REQ_COPY flag), with interface accommodating
> two block-devs, and multi-source/destination interface
> - Emulation, when offload is natively absent
> - dm-linear support (for cases not requiring split)
>
> 3. User-interface
> - new ioctl
> - copy_file_range for zonefs
>
> 4. In-kernel user
> - dm-kcopyd
> - copy_file_range in zonefs
>
> For zonefs copy_file_range - Seems we cannot levearge fstest here. Limited
> testing is done at this point using a custom application for unit testing.

https://github.com/westerndigitalcorporation/zonefs-tools

./configure --with-tests
make
sudo make install

Then run tests/zonefs-tests.sh

Adding test case is simple. Just add script files under tests/scripts

I just realized that the README file of this project is not documenting
this. I will update it.

>
> Appreciate the inputs on plumbing and how to test this further?
> Perhaps some of it can be discussed during LSF/MM too.
>
> [0] https://lore.kernel.org/linux-nvme/CA+1E3rJ7BZ7LjQXXTdX+-0Edz=zT14mmPGMiVCzUgB33C60tbQ@mail.gmail.com/
>
> Changes in v4:
> - added copy_file_range support for zonefs
> - added documentaion about new sysfs entries
> - incorporated review comments on v3
> - minor fixes
>
>
> Arnav Dawn (2):
> nvmet: add copy command support for bdev and file ns
> fs: add support for copy file range in zonefs
>
> Nitesh Shetty (7):
> block: Introduce queue limits for copy-offload support
> block: Add copy offload support infrastructure
> block: Introduce a new ioctl for copy
> block: add emulation for copy
> nvme: add copy offload support
> dm: Add support for copy offload.
> dm: Enable copy offload for dm-linear target
>
> SelvaKumar S (1):
> dm kcopyd: use copy offload support
>
> Documentation/ABI/stable/sysfs-block | 83 +++++++
> block/blk-lib.c | 358 +++++++++++++++++++++++++++
> block/blk-map.c | 2 +-
> block/blk-settings.c | 59 +++++
> block/blk-sysfs.c | 138 +++++++++++
> block/blk.h | 2 +
> block/ioctl.c | 32 +++
> drivers/md/dm-kcopyd.c | 55 +++-
> drivers/md/dm-linear.c | 1 +
> drivers/md/dm-table.c | 45 ++++
> drivers/md/dm.c | 6 +
> drivers/nvme/host/core.c | 116 ++++++++-
> drivers/nvme/host/fc.c | 4 +
> drivers/nvme/host/nvme.h | 7 +
> drivers/nvme/host/pci.c | 25 ++
> drivers/nvme/host/rdma.c | 6 +
> drivers/nvme/host/tcp.c | 14 ++
> drivers/nvme/host/trace.c | 19 ++
> drivers/nvme/target/admin-cmd.c | 8 +-
> drivers/nvme/target/io-cmd-bdev.c | 65 +++++
> drivers/nvme/target/io-cmd-file.c | 49 ++++
> fs/zonefs/super.c | 178 ++++++++++++-
> fs/zonefs/zonefs.h | 1 +
> include/linux/blk_types.h | 21 ++
> include/linux/blkdev.h | 17 ++
> include/linux/device-mapper.h | 5 +
> include/linux/nvme.h | 43 +++-
> include/uapi/linux/fs.h | 23 ++
> 28 files changed, 1367 insertions(+), 15 deletions(-)
>
>
> base-commit: e7d6987e09a328d4a949701db40ef63fbb970670

--
Damien Le Moal
Western Digital Research