From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, io-uring@vger.kernel.org,
linux-nvme@lists.infradead.org, asml.silence@gmail.com,
ming.lei@redhat.com, mcgrof@kernel.org, shr@fb.com,
joshiiitr@gmail.com, gost.dev@samsung.com
Subject: Re: [PATCH v3 2/5] block: wire-up support for passthrough plugging
Date: Tue, 3 May 2022 22:53:01 +0200 [thread overview]
Message-ID: <20220503205301.GB9567@lst.de> (raw)
In-Reply-To: <20220503184831.78705-3-p.raghav@samsung.com>
> + if (plug) {
> + blk_add_rq_to_plug(plug, rq);
> + } else {
I'd just do an eary return after the blk_add_rq_to_plug call and leave
the rest of the code untouched and unindented.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-05-03 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220503184911eucas1p1beb172219537d78fcaf2a1417f532cf7@eucas1p1.samsung.com>
2022-05-03 18:48 ` [PATCH v3 0/5] io_uring passthough for nvme Pankaj Raghav
2022-05-03 18:48 ` [PATCH v3 1/5] fs,io_uring: add infrastructure for uring-cmd Pankaj Raghav
2022-05-03 20:52 ` Christoph Hellwig
2022-05-04 15:12 ` Kanchan Joshi
2022-05-04 12:09 ` Jens Axboe
2022-05-04 15:48 ` Kanchan Joshi
2022-05-03 21:03 ` Jens Axboe
2022-05-03 18:48 ` [PATCH v3 2/5] block: wire-up support for passthrough plugging Pankaj Raghav
2022-05-03 20:53 ` Christoph Hellwig [this message]
2022-05-03 18:48 ` [PATCH v3 3/5] nvme: refactor nvme_submit_user_cmd() Pankaj Raghav
2022-05-03 18:48 ` [PATCH v3 4/5] nvme: wire-up uring-cmd support for io-passthru on char-device Pankaj Raghav
2022-05-03 20:55 ` Christoph Hellwig
2022-05-03 18:48 ` [PATCH v3 5/5] nvme: add vectored-io support for uring-cmd Pankaj Raghav
2022-05-03 20:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503205301.GB9567@lst.de \
--to=hch@lst.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshiiitr@gmail.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=p.raghav@samsung.com \
--cc=shr@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox