Re: [PATCH] nvme: set dma alignment to 3

Christoph Hellwig
2022-05-05T13:45:52Z

On Wed, May 04, 2022 at 11:43:25AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The nvme specification only requires qword alignment for segment
> descriptors, and the driver already guarantees that. The spec has always
> allowed user data to be dword aligned, which is what the queue's
> attribute is for, so relax the alignment requirement to that value.
>
> While we could allow byte alignment for some controllers when using
> SGLs, we still need to support PRP, and that only allows dword.

Can't we just turn it go up to eleven? ;-)