From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 2/3] nvme-tcp: Check for write space before queueing requests
Date: Thu, 19 May 2022 08:26:16 +0200 [thread overview]
Message-ID: <20220519062617.39715-3-hare@suse.de> (raw)
In-Reply-To: <20220519062617.39715-1-hare@suse.de>
The current model of always queue incoming requests lead to
write stalls as we easily overload the network device under
high I/O load.
To avoid unlimited queueing we should rather check if write
space is available before accepting new requests.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/tcp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index ede76a0719a0..606565a4c708 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2464,6 +2464,9 @@ static blk_status_t nvme_tcp_queue_rq(struct blk_mq_hw_ctx *hctx,
if (unlikely(ret))
return ret;
+ if (!sk_stream_is_writeable(queue->sock->sk))
+ return BLK_STS_RESOURCE;
+
blk_mq_start_request(rq);
nvme_tcp_queue_request(req, true, bd->last);
--
2.29.2
next prev parent reply other threads:[~2022-05-19 6:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 6:26 [PATCH 0/3] nvme-tcp: queue stalls under high load Hannes Reinecke
2022-05-19 6:26 ` [PATCH 1/3] nvme-tcp: spurious I/O timeout " Hannes Reinecke
2022-05-20 9:05 ` Sagi Grimberg
2022-05-23 8:42 ` Hannes Reinecke
2022-05-23 13:36 ` Sagi Grimberg
2022-05-23 14:01 ` Hannes Reinecke
2022-05-23 15:05 ` Sagi Grimberg
2022-05-23 16:07 ` Hannes Reinecke
2022-05-24 7:57 ` Sagi Grimberg
2022-05-24 8:08 ` Hannes Reinecke
2022-05-24 8:53 ` Sagi Grimberg
2022-05-24 9:34 ` Hannes Reinecke
2022-05-24 9:58 ` Sagi Grimberg
2022-05-19 6:26 ` Hannes Reinecke [this message]
2022-05-20 9:17 ` [PATCH 2/3] nvme-tcp: Check for write space before queueing requests Sagi Grimberg
2022-05-20 10:05 ` Hannes Reinecke
2022-05-21 20:01 ` Sagi Grimberg
2022-05-19 6:26 ` [PATCH 3/3] nvme-tcp: send quota for nvme_tcp_send_all() Hannes Reinecke
2022-05-20 9:19 ` Sagi Grimberg
2022-05-20 9:59 ` Hannes Reinecke
2022-05-21 20:02 ` Sagi Grimberg
2022-05-20 9:20 ` [PATCH 0/3] nvme-tcp: queue stalls under high load Sagi Grimberg
2022-05-20 10:01 ` Hannes Reinecke
2022-05-21 20:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519062617.39715-3-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox