public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: hch@lst.de, kbusch@kernel.org, axboe@kernel.dk,
	linux-nvme@lists.infradead.org, gost.dev@samsung.com,
	joshiiitr@gmail.com
Subject: Re: [PATCH v2 0/2] uring-passthrough for admin commands
Date: Fri, 20 May 2022 08:01:43 +0200	[thread overview]
Message-ID: <20220520060143.GA16433@lst.de> (raw)
In-Reply-To: <20220520045600.3773-1-joshi.k@samsung.com>

On Fri, May 20, 2022 at 10:25:58AM +0530, Kanchan Joshi wrote:
> The series enables uring-passthrough for admin-commands.
> 
> Patch 1 is prep.
> Patch 2 adds new opcode for admin uring-passthrough, and enables it on
> nvme controller dev(/dev/nvmeX). It reuses the code of io-command
> passthrough, with the only difference that commands are issued on admin
> queue.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Can we add vectored admin commands as well, please?  We basically
get them for free, so I see no reason not to add them.


  parent reply	other threads:[~2022-05-20  6:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220520050118epcas5p1f6a930419285ecdac65afaa22255c03f@epcas5p1.samsung.com>
2022-05-20  4:55 ` [PATCH v2 0/2] uring-passthrough for admin commands Kanchan Joshi
2022-05-20  4:55   ` [PATCH v2 1/2] nvme: helper for uring-passthrough checks Kanchan Joshi
2022-05-20  4:56   ` [PATCH v2 2/2] nvme: enable uring-passthrough for admin commands Kanchan Joshi
2022-05-20  6:01   ` Christoph Hellwig [this message]
2022-05-20  8:21     ` [PATCH v2 0/2] " Kanchan Joshi
2022-05-20  9:15       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520060143.GA16433@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=joshi.k@samsung.com \
    --cc=joshiiitr@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox