Re: [PATCH 4/9] nvme: Implement In-Band authentication

Hannes Reinecke
2022-06-08T06:01:39Z

On 6/7/22 12:49, Christoph Hellwig wrote:
> On Fri, May 27, 2022 at 10:04:52AM +0200, Hannes Reinecke wrote:
>> +config NVME_AUTH
>> + bool "NVM Express over Fabrics In-Band Authentication"
>> + depends on NVME_CORE
>
> Does this actually depend on NVME_CORE? As that would suck when pulling
> this code into the target driver as well. Also in addition to the header
> location already mentioned by Max, this should probably go into
> drivers/nvme/common/ if used by the host and target code.
>
That would mean to create another nvme module (nvme-common.o?), which
would need to be pulled in by both, host and target code.
And really it's just the one file in drivers/nvme/host/auth.c.
Sure I can do that if you think that's better ...

>> + This provides support for NVMe over Fabrics In-Band Authentication.
>
> This should probably mention that the support can be used both by the
> host and target code.

Right. Will be doing it.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman