Re: [PATCH 4/9] nvme: Implement In-Band authentication

Christoph Hellwig
2022-06-07T10:53:25Z

On Fri, May 27, 2022 at 10:04:52AM +0200, Hannes Reinecke wrote:
> +config NVME_AUTH
> + bool "NVM Express over Fabrics In-Band Authentication"
> + depends on NVME_CORE

Does this actually depend on NVME_CORE? As that would suck when pulling
this code into the target driver as well. Also in addition to the header
location already mentioned by Max, this should probably go into
drivers/nvme/common/ if used by the host and target code.

> + This provides support for NVMe over Fabrics In-Band Authentication.

This should probably mention that the support can be used both by the
host and target code.