From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2272C433EF for ; Tue, 31 May 2022 19:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Mbib1ViGeF93pbpt1Bcfb59VC28wz2gnpd4HmD/hJts=; b=cDdbOIsC+PVKo+sx0lRcEuPmfk IQ/h2zCDFRGlCLoBnKnBC8YVi+lGSd/UvPfqelKA49iuWeDfSKgH7JQY+AQ2fkIx4YU5MW6wANSGY 3X3n+OlMz8bWKtqeQBDv3xawqPtxnHDOdcmffRP6X+C8wTadUfHwf5158FghqV9odsIJtu40nkgKJ NAk8N33ORXCPx2qXwQrLQxeFlemd0b8XYrq8INHZ0LbBTglrX3i0kbrUSgM8tWLExH1URwyfmnn86 NYwYN4+Nl9JzunMGOoYJPg1qnPxYi2xEtvhXvBr9DNiQQbkrxjrhxxkuJOnUEMzacssn3IHDku0/g Rr3HCppQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw7Md-00CIUA-PP; Tue, 31 May 2022 19:17:11 +0000 Received: from mx0b-00082601.pphosted.com ([67.231.153.30] helo=mx0a-00082601.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw7MU-00CIN0-LQ for linux-nvme@lists.infradead.org; Tue, 31 May 2022 19:17:04 +0000 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 24VFiHXS013628 for ; Tue, 31 May 2022 12:16:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=facebook; bh=Mbib1ViGeF93pbpt1Bcfb59VC28wz2gnpd4HmD/hJts=; b=AWQUm4u+BfxjPb8xSB0y0h6y1hQbdqNC04gGkOZoktGVMtiidHvuuuQg7+qAgSp0YlCu SP6xKkCbJJOb3f/u02y8auTIcLtZ0s1eW+aA1s+cC8ZI0IuPg6ZAsbocFTCLLnHTMir2 kSpA0u2Xm5KdaKFYFidwnacqKIHyOormT9c= Received: from mail.thefacebook.com ([163.114.132.120]) by m0001303.ppops.net (PPS) with ESMTPS id 3gbfdtg5gc-10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 31 May 2022 12:16:58 -0700 Received: from twshared19572.14.frc2.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 31 May 2022 12:16:56 -0700 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id C123E4924B08; Tue, 31 May 2022 12:11:38 -0700 (PDT) From: Keith Busch To: , , CC: , Kernel Team , , , , , , Keith Busch Subject: [PATCHv5 00/11] direct-io dma alignment Date: Tue, 31 May 2022 12:11:26 -0700 Message-ID: <20220531191137.2291467-1-kbusch@fb.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: YKAeqfs3GfcxyMP9SijCqRs2kO9iDtqa X-Proofpoint-GUID: YKAeqfs3GfcxyMP9SijCqRs2kO9iDtqa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_07,2022-05-30_03,2022-02-23_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_121702_895115_8BDE101C X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Keith Busch The most significant change from v4 is the alignment is now checked prior to building the bio. This gets the expected EINVAL error for misaligned userspace iovecs in all cases now (Eric Biggers). I've removed the legacy fs change, so only iomap filesystems get to use this alignement capability (Christoph Hellwig). The block fops check for alignment returns a bool now (Damien). Adjusted some comments, docs, and other minor style issues. Reviews added for unchanged or trivially changed patches, removed reviews for ones that changed more significantly. As before, I tested using 'fio' with forced misaligned user buffers on raw block, xfs, and ext4 (example raw block profile below). [global] filename=3D/dev/nvme0n1 ioengine=3Dio_uring verify=3Dcrc32c rw=3Drandwrite iodepth=3D64 direct=3D1 [small] stonewall bsrange=3D4k-64k iomem_align=3D4 [large] stonewall bsrange=3D512k-4M iomem_align=3D100 Keith Busch (11): block: fix infinite loop for invalid zone append block/bio: remove duplicate append pages code block: export dma_alignment attribute block: introduce bdev_dma_alignment helper block: add a helper function for dio alignment block/merge: count bytes instead of sectors block/bounce: count bytes instead of sectors iov: introduce iov_iter_aligned block: introduce bdev_iter_is_aligned helper block: relax direct io memory alignment fs: add support for dma aligned direct-io Documentation/ABI/stable/sysfs-block | 9 +++ block/bio.c | 114 ++++++++++++--------------- block/blk-merge.c | 41 ++++++---- block/blk-sysfs.c | 7 ++ block/bounce.c | 13 ++- block/fops.c | 16 ++-- fs/iomap/direct-io.c | 4 +- include/linux/blkdev.h | 12 +++ include/linux/uio.h | 2 + lib/iov_iter.c | 92 +++++++++++++++++++++ 10 files changed, 219 insertions(+), 91 deletions(-) --=20 2.30.2