From: "hch@lst.de" <hch@lst.de>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: Keith Busch <kbusch@kernel.org>, "axboe@fb.com" <axboe@fb.com>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Caroline Subramoney <Caroline.Subramoney@microsoft.com>,
Richard Wurdack <riwurd@microsoft.com>,
Nathan Obr <Nathan.Obr@microsoft.com>
Subject: Re: [PATCH v2 2/2] nvme: handle persistent internal error AER from NVMe controller
Date: Mon, 6 Jun 2022 08:51:02 +0200 [thread overview]
Message-ID: <20220606065102.GA2551@lst.de> (raw)
In-Reply-To: <PH0PR21MB3025781A702070304BB8A282D7A09@PH0PR21MB3025.namprd21.prod.outlook.com>
On Sat, Jun 04, 2022 at 02:28:11PM +0000, Michael Kelley (LINUX) wrote:
> > driver's irq handler. The other transports block on register reads, though, so
> > they can't call this from an atomic context. The TCP context looks safe, but
> > I'm not sure about RDMA or FC.
>
> Good point. But even if the RDMA and FC contexts are safe,
For RDMA this is typically called from softirq context, so it is indeed
not save.
> if a
> persistent error is reported, the controller is already in trouble and
> may not respond to a request to retrieve the CSTS anyway. Perhaps
> we should just trust the AER error report and not bother checking
> CSTS to decide whether to do the reset. We can still check ctrl->state
> and skip the reset if there's already one in progress.
Yes, that might be a better option.
next prev parent reply other threads:[~2022-06-06 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 17:56 [PATCH v2 1/2] nvme-pci: move nvme_should_reset() to core code Michael Kelley
2022-06-03 17:56 ` [PATCH v2 2/2] nvme: handle persistent internal error AER from NVMe controller Michael Kelley
2022-06-03 19:23 ` Keith Busch
2022-06-04 14:28 ` Michael Kelley (LINUX)
2022-06-06 6:51 ` hch [this message]
2022-06-06 16:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606065102.GA2551@lst.de \
--to=hch@lst.de \
--cc=Caroline.Subramoney@microsoft.com \
--cc=Nathan.Obr@microsoft.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mikelley@microsoft.com \
--cc=riwurd@microsoft.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox