From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Yi Zhang <yi.zhang@redhat.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>
Subject: Re: [bug report] WARNING: possible circular locking at: rdma_destroy_id+0x17/0x20 [rdma_cm] triggered by blktests nvmeof-mp/002
Date: Mon, 6 Jun 2022 13:21:01 -0300 [thread overview]
Message-ID: <20220606162101.GA3932382@ziepe.ca> (raw)
In-Reply-To: <53951a52-dc77-f4c9-a1dc-d6ac015be1a4@acm.org>
On Thu, Jun 02, 2022 at 10:13:25PM -0700, Bart Van Assche wrote:
> On 6/1/22 10:30, Jason Gunthorpe wrote:
> > That is just the keys, not the graph arcs. lockdep records an arc
> > between every key that establishes a locking relationship and
> > minimizing the number of keys also de-duplicates those arcs.
>
> Do you agree that this overhead is acceptable since lockdep is only
> used to debug kernel code?
I don't know lockdep well enough to know - if you bloat the graph too
much it may become excessively slow when searching for
cycles/edges. Debug workloads with CM may trigger creating of 1000's
of keys and we still want the testing to be workable.
IMHO it was not designed to have one key per instance.
Jason
next prev parent reply other threads:[~2022-06-06 16:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 3:04 [bug report] WARNING: possible circular locking at: rdma_destroy_id+0x17/0x20 [rdma_cm] triggered by blktests nvmeof-mp/002 Yi Zhang
2022-02-27 23:21 ` Bart Van Assche
2022-05-25 3:40 ` yangx.jy
2022-05-25 11:01 ` Sagi Grimberg
2022-05-25 18:50 ` Bart Van Assche
2022-05-27 12:52 ` Jason Gunthorpe
2022-05-28 19:00 ` Bart Van Assche
2022-05-31 12:35 ` Jason Gunthorpe
2022-05-31 17:55 ` Bart Van Assche
2022-06-01 12:45 ` Jason Gunthorpe
2022-06-01 16:26 ` Bart Van Assche
2022-06-01 17:30 ` Jason Gunthorpe
2022-06-03 5:13 ` Bart Van Assche
2022-06-06 16:21 ` Jason Gunthorpe [this message]
2022-08-23 7:29 ` yangx.jy
2022-08-25 5:59 ` yangx.jy
2022-08-25 6:26 ` Guoqing Jiang
2022-08-26 10:03 ` yangx.jy
2022-08-26 11:32 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606162101.GA3932382@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox