Re: [PATCH 3/6] nvme-core: remove qid parameter

Christoph Hellwig
2022-06-07T05:59:45Z

On Tue, Jun 07, 2022 at 05:57:02AM +0000, Chaitanya Kulkarni wrote:
> On 6/6/22 21:39, Christoph Hellwig wrote:
> > On Mon, Jun 06, 2022 at 06:16:44PM -0700, Chaitanya Kulkarni wrote:
> >> We can easily derive the qid value from the nvme_command parameter of
> >> the function __nvme_submit_sync_cmd() when its caller is
> >> nvmf_connect_io_queue().
> >
> > This is a pretty horrible layering violation. The low-level submit
> > helpers should no known about the contents of the payload.
>
> Okay, we can ignore this series then.

The first patches still look good to me, though.