* [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50
@ 2022-06-06 13:01 Stefan Reiter
2022-06-06 15:07 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Reiter @ 2022-06-06 13:01 UTC (permalink / raw)
To: linux-nvme, Christoph Hellwig, Keith Busch, Sagi Grimberg; +Cc: Stefan Reiter
ADATA XPG GAMMIX S50 drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are
not marked as "non globally unique" duplicates.
Signed-off-by: Stefan Reiter <stefan@pimaker.at>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 48f4f6eb877b..f1578663cafb 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3463,6 +3463,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1e4B, 0x1202), /* MAXIO MAP1202 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1cc1, 0x5350), /* ADATA XPG GAMMIX S50 */
+ .driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061),
.driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, },
{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065),
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50
2022-06-06 13:01 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50 Stefan Reiter
@ 2022-06-06 15:07 ` Christoph Hellwig
2022-06-06 17:17 ` Chaitanya Kulkarni
2022-06-07 10:16 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-06-06 15:07 UTC (permalink / raw)
To: Stefan Reiter; +Cc: linux-nvme, Christoph Hellwig, Keith Busch, Sagi Grimberg
Thanks,
I'll add this to the nvme-5.19 tree in a bit.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50
2022-06-06 13:01 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50 Stefan Reiter
2022-06-06 15:07 ` Christoph Hellwig
@ 2022-06-06 17:17 ` Chaitanya Kulkarni
2022-06-07 10:16 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2022-06-06 17:17 UTC (permalink / raw)
To: Stefan Reiter, linux-nvme@lists.infradead.org, Christoph Hellwig,
Keith Busch, Sagi Grimberg
On 6/6/22 06:01, Stefan Reiter wrote:
> ADATA XPG GAMMIX S50 drives report bogus eui64 values that appear to
> be the same across drives in one system. Quirk them out so they are
> not marked as "non globally unique" duplicates.
>
> Signed-off-by: Stefan Reiter <stefan@pimaker.at>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50
2022-06-06 13:01 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50 Stefan Reiter
2022-06-06 15:07 ` Christoph Hellwig
2022-06-06 17:17 ` Chaitanya Kulkarni
@ 2022-06-07 10:16 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-06-07 10:16 UTC (permalink / raw)
To: Stefan Reiter; +Cc: linux-nvme, Christoph Hellwig, Keith Busch, Sagi Grimberg
Thanks,
applied to nvme-5.19.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-07 10:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-06 13:01 [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG GAMMIX S50 Stefan Reiter
2022-06-06 15:07 ` Christoph Hellwig
2022-06-06 17:17 ` Chaitanya Kulkarni
2022-06-07 10:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox