From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Michael Liang <mliang@purestorage.com>
Subject: Re: [PATCH] nvme: don't send unsupported NVME_ID_CNS_CS_CTRL
Date: Wed, 8 Jun 2022 18:05:52 +0200 [thread overview]
Message-ID: <20220608160552.GA18189@lst.de> (raw)
In-Reply-To: <20220608160305.1781896-1-csander@purestorage.com>
On Wed, Jun 08, 2022 at 10:03:05AM -0600, Caleb Sander wrote:
> Identify CNS values 0x05 to 0x0F are reserved in NVMe base spec 1.4.
> 0x06 was only added in spec 2.0. Our array implementing spec version 1.3
> correctly responds to this Identify with "Invalid Field in Command".
> The driver ignores an error status code here, but the reserved CNS value
> violates the spec and causes unnecessary traffic on the NVMe connection.
No, it does not "violate" the spec. All NVMe TPs can be implement
for older spec versions as well, and regularly do. So yes, your
array will return an error here and that is perfectly fine.
prev parent reply other threads:[~2022-06-08 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 16:03 [PATCH] nvme: don't send unsupported NVME_ID_CNS_CS_CTRL Caleb Sander
2022-06-08 16:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608160552.GA18189@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=csander@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mliang@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox