From: Christoph Hellwig <hch@lst.de>
To: Vitaly Mayatskikh <vitaly@enfabrica.net>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme-multipath: allocate MQ disk
Date: Fri, 10 Jun 2022 07:59:57 +0200 [thread overview]
Message-ID: <20220610055957.GA24331@lst.de> (raw)
In-Reply-To: <20220609173734.381654-1-vitaly@enfabrica.net>
On Thu, Jun 09, 2022 at 01:37:34PM -0400, Vitaly Mayatskikh wrote:
> nvme_mpath_alloc_disk() allocates gendisk with blk_alloc_disk(), which
> results in no MQ support even if the head device has it.
This can't work. Can you explain hw you came up with this idea and
why you decided to send it out without any testing at all?
next prev parent reply other threads:[~2022-06-10 6:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 17:37 [PATCH] nvme-multipath: allocate MQ disk Vitaly Mayatskikh
2022-06-09 17:49 ` Keith Busch
2022-06-09 18:23 ` Vitaly Mayatskikh
2022-06-10 5:59 ` Christoph Hellwig [this message]
2022-06-10 14:25 ` Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610055957.GA24331@lst.de \
--to=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=vitaly@enfabrica.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox