Re: [PATCHv5 blktests 00/10] Testsuite for nvme in-band authentication

Shinichiro Kawasaki
2022-06-14T05:07:23Z

Hi Hannes, thanks for sharing the series. Here are general minor comments on it.

- Newly added test case scripts have file mode 644. I recommend 755 to indicate
that they are executable and to keep consistency with other test cases.
- Could you please run "make check" and address shellcheck warnings? Shellcheck
is good to reduce human-error, and I wish to keep zero warning.
- In the series, I observe bash condition expressions with single brackets []
and double brackets [[ ]] are mixed. Originally double brackets were
recommended for blktests scripts then I rather prefer double brackets. Having
said that many single brackets are already used in blktests, so single bracket
is still ok.

--
Shin'ichiro Kawasaki