Re: [PATCHv6 06/11] block/merge: count bytes instead of sectors

Bart Van Assche
2022-07-22T22:06:30Z

On 6/10/22 12:58, Keith Busch wrote:
> @@ -269,8 +269,8 @@ static struct bio *blk_bio_segment_split(struct request_queue *q,
> {
> struct bio_vec bv, bvprv, *bvprvp = NULL;
> struct bvec_iter iter;
> - unsigned nsegs = 0, sectors = 0;
> - const unsigned max_sectors = get_max_io_size(q, bio);
> + unsigned nsegs = 0, bytes = 0;
> + const unsigned max_bytes = get_max_io_size(q, bio) << 9;

How about using SECTOR_SHIFT instead of 9?

Thanks,

Bart.