From: Christoph Hellwig <hch@lst.de>
To: Joel Granados <j.granados@samsung.com>
Cc: hch@lst.de, kbusch@kernel.org, joshi.k@samsung.com,
linux-nvme@lists.infradead.org, gost.dev@samsung.com,
k.jensen@samsung.com
Subject: Re: [PATCH v2 1/2] nvme-multipath: refactor nvme_mpath_add_disk
Date: Mon, 13 Jun 2022 20:16:20 +0200 [thread overview]
Message-ID: <20220613181620.GA16299@lst.de> (raw)
In-Reply-To: <20220607134055.1742162-2-j.granados@samsung.com>
> +++ b/drivers/nvme/host/multipath.c
> @@ -3,6 +3,7 @@
> * Copyright (c) 2017-2018 Christoph Hellwig.
> */
>
> +#include "linux/types.h"
Please always use <> style includes for system headers. But I don't
think we even need this include.
next prev parent reply other threads:[~2022-06-13 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220607134309eucas1p1724cee80a5bc116c652e91422d474ccd@eucas1p1.samsung.com>
2022-06-07 13:40 ` [PATCH v2 0/2] nvme: Enable generic interface (/dev/ngX) for unknown command sets Joel Granados
2022-06-07 13:40 ` [PATCH v2 1/2] nvme-multipath: refactor nvme_mpath_add_disk Joel Granados
2022-06-13 18:16 ` Christoph Hellwig [this message]
2022-06-15 7:50 ` Joel Granados
2022-06-07 13:40 ` [PATCH v2 2/2] nvme: enable generic interface (/dev/ngXnY) for unknown command sets Joel Granados
2022-06-13 18:24 ` Christoph Hellwig
2022-06-15 11:20 ` Joel Granados
2022-06-15 14:50 ` Joel Granados
2022-06-22 14:11 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613181620.GA16299@lst.de \
--to=hch@lst.de \
--cc=gost.dev@samsung.com \
--cc=j.granados@samsung.com \
--cc=joshi.k@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox