From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D54CCA47D for ; Mon, 13 Jun 2022 18:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dsJI32uCqI3ESqBd2k8Zc9gcPx8EoPea2IA1MaQbpPs=; b=N58nv3Br6gaF3xmidDDmigeXDC Bwo5PW6SgeAnLW1EXx/VsgAfgdkWhQYVUU4MOYl6a1r/0COAQv3u+LQVJrpwwScuzabR2kU4K0Hvk hQKiwZ9lbhcUdMVoQ9/S3tUGYWu6/GeLPFuJ6ONxBFQHkDtcO6+11sZRi/1f3vyXcN+d6M6jyVhmQ mR+tWApel+os3edV6NjcK0KPTJpOkushfboppgfyYPS4zWWldDAQoUHV/MQ5f629HkhT910C/aLfy ZBwgkraTOmOPosbU0EBygcqQehkKVIPaKWAgSxhxhx0lKqLSIg7wd+PR7u7HodUjM/4li8lJ4FaSZ wdDXtlWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0obx-0057qz-RP; Mon, 13 Jun 2022 18:16:25 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0obv-0057qC-Cv for linux-nvme@lists.infradead.org; Mon, 13 Jun 2022 18:16:24 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id ADB5E68AA6; Mon, 13 Jun 2022 20:16:20 +0200 (CEST) Date: Mon, 13 Jun 2022 20:16:20 +0200 From: Christoph Hellwig To: Joel Granados Cc: hch@lst.de, kbusch@kernel.org, joshi.k@samsung.com, linux-nvme@lists.infradead.org, gost.dev@samsung.com, k.jensen@samsung.com Subject: Re: [PATCH v2 1/2] nvme-multipath: refactor nvme_mpath_add_disk Message-ID: <20220613181620.GA16299@lst.de> References: <20220607134055.1742162-1-j.granados@samsung.com> <20220607134055.1742162-2-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607134055.1742162-2-j.granados@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_111623_621702_765D0DBC X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > +++ b/drivers/nvme/host/multipath.c > @@ -3,6 +3,7 @@ > * Copyright (c) 2017-2018 Christoph Hellwig. > */ > > +#include "linux/types.h" Please always use <> style includes for system headers. But I don't think we even need this include.