Re: [PATCH v2] nvme-tcp: use in-capsule data for I/O connect

Christoph Hellwig
2022-07-08T05:00:56Z

On Thu, Jul 07, 2022 at 03:12:45PM -0600, Caleb Sander wrote:
> >From the NVMe/TCP spec:
> > The maximum amount of in-capsule data for Fabrics and Admin Commands
> > is 8,192 bytes ... NVMe/TCP controllers must support in-capsule data
> > for Fabrics and Admin Command Capsules
>
> Currently, command data is only sent in-capsule on the admin queue
> or I/O queues that indicate support for it.
> Send fabrics command data in-capsule for I/O queues too to avoid
> needing a separate H2CData PDU for the connect command.

While I'm fine with this change, can you please state here why this
is important? Is there a use case where it really matters? A controller
that is unhappy if this doesn't happen?