From: Christoph Hellwig <hch@lst.de>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Klaus Jensen <its@irrelevant.dk>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique
Date: Fri, 17 Jun 2022 11:01:00 +0200 [thread overview]
Message-ID: <20220617090100.GA7767@lst.de> (raw)
In-Reply-To: <B396ED69-5559-40F0-92F3-8B319D90584C@oracle.com>
On Wed, Jun 15, 2022 at 08:15:18PM +0000, Alan Adamson wrote:
> Here are my latest changes. It includes an interface from nvme-cli to specify
> to clear the IDs upon connect.
>
> Wasn’t sure the proper way to send a clear_ids argument to the target so I followed
> what kato did. Not sure if that is appropriate for this case.
>
> This will require a nvme-cli change and blktests changes. I tested with both loop and tcp.
Well, it changes the nvme over the wire protocol, we can't just do
that.
And the option really is a target side one, that is we want to configure
it using configfs on the target, not the fabrics command line options.
That is, add a new clear_ids attribute to nvmet_passthru_attrs, save
the flag in struct nvmet_subsys, and default to true for loop controllers.
next prev parent reply other threads:[~2022-06-17 9:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 19:28 properly validate the nvme uniqueue identifiers are unique v2 Christoph Hellwig
2022-02-24 19:28 ` [PATCH 1/4] nvme: cleanup __nvme_check_ids Christoph Hellwig
2022-02-24 22:50 ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 2/4] nvme: fix the check for duplicate unique identifiers Christoph Hellwig
2022-02-24 22:51 ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 3/4] nvme: check for duplicate identifiers earlier Christoph Hellwig
2022-02-24 22:52 ` Chaitanya Kulkarni
2022-02-24 19:28 ` [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Christoph Hellwig
2022-02-24 22:54 ` Chaitanya Kulkarni
2022-04-08 1:04 ` Luis Chamberlain
2022-04-08 5:29 ` Christoph Hellwig
2022-04-08 7:19 ` Klaus Jensen
2022-04-08 16:10 ` Christoph Hellwig
2022-04-08 17:46 ` Luis Chamberlain
2022-04-11 5:05 ` Christoph Hellwig
2022-04-11 5:54 ` Christoph Hellwig
2022-04-11 6:01 ` Klaus Jensen
2022-04-11 6:09 ` Christoph Hellwig
2022-04-11 6:11 ` Klaus Jensen
2022-04-12 18:46 ` Luis Chamberlain
2022-04-18 23:30 ` Alan Adamson
2022-04-20 7:36 ` Christoph Hellwig
2022-06-06 20:35 ` Alan Adamson
2022-06-06 21:38 ` Keith Busch
2022-06-06 21:51 ` Alan Adamson
2022-06-06 21:58 ` Keith Busch
2022-06-06 23:11 ` Alan Adamson
2022-06-07 19:01 ` Keith Busch
2022-06-08 7:48 ` Christoph Hellwig
2022-06-08 7:52 ` Christoph Hellwig
2022-06-08 18:11 ` Alan Adamson
2022-06-08 19:04 ` Keith Busch
2022-06-09 0:30 ` Chaitanya Kulkarni
2022-06-09 15:11 ` Alan Adamson
2022-06-09 3:53 ` Christoph Hellwig
2022-06-10 0:27 ` Alan Adamson
2022-06-10 14:12 ` Keith Busch
2022-06-15 20:15 ` Alan Adamson
2022-06-17 9:01 ` Christoph Hellwig [this message]
2022-06-21 18:40 ` Alan Adamson
2022-06-21 19:11 ` Keith Busch
2022-06-21 20:39 ` Alan Adamson
2022-06-22 11:00 ` Christoph Hellwig
2022-06-22 15:45 ` Alan Adamson
2022-02-24 19:38 ` properly validate the nvme uniqueue identifiers are unique v2 Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2022-06-05 1:58 [PATCH 4/4] nvme: check that EUI/GUID/UUID are globally unique Stefan
2022-06-06 6:40 ` Christoph Hellwig
2022-06-06 12:42 ` Stefan
2022-06-06 15:03 ` Christoph Hellwig
2022-06-06 14:51 ` Keith Busch
2022-06-06 15:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617090100.GA7767@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox