From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88315C43334 for ; Tue, 5 Jul 2022 08:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LynicjJbX8kxEsTuM3n41XIQVL1TZ/xn1yu/W9ObKlQ=; b=XUSqAa81zzeYVDpYlVaj3vhMT2 dsoD09HLaYo3Gc1hTTolR62jqkPwszJTu73dlUzAJ3rIOE4Xy4KAkpKQuMRRWIBV0O6VP0e31YimM nIH+2LGWILB+h9npxDPJY9Rk8/5YnqeQHvyx7aWf5yBb583dysLULFETBfgYDhxRIP2Jl6wZlhvED huB6IW4B9ndQ/BNn9UPTvu2pj8q9rdP0Jsx6+ZYMqjiBVYTpeXGQ/CZElMjDH9subFff/6FlpsEu/ 4Q9wyh1igTaUYAT3CwowxbqfdWvfiGmtlX0HOJsuWBFdTqnB075W+yAEd4CIRss3Hmm/ekDhkioX3 7o0Yf62A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8e53-00GGXC-Ti; Tue, 05 Jul 2022 08:38:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8e39-00GFkf-PR for linux-nvme@lists.infradead.org; Tue, 05 Jul 2022 08:36:53 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CBA7068AA6; Tue, 5 Jul 2022 10:36:48 +0200 (CEST) Date: Tue, 5 Jul 2022 10:36:48 +0200 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, agk@redhat.com, song@kernel.org, djwong@kernel.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, javier@javigon.com, johannes.thumshirn@wdc.com, bvanassche@acm.org, dongli.zhang@oracle.com, ming.lei@redhat.com, willy@infradead.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, clm@fb.com, dsterba@suse.com, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, jlayton@kernel.org, idryomov@gmail.com, danil.kipnis@cloud.ionos.com, ebiggers@google.com, jinpu.wang@cloud.ionos.com Subject: Re: [PATCH 5/6] nvmet: add verify emulation support for file-ns Message-ID: <20220705083648.GD19123@lst.de> References: <20220630091406.19624-1-kch@nvidia.com> <20220630091406.19624-6-kch@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630091406.19624-6-kch@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_013652_016339_907D5B25 X-CRM114-Status: GOOD ( 12.51 ) X-Mailman-Approved-At: Tue, 05 Jul 2022 01:38:36 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jun 30, 2022 at 02:14:05AM -0700, Chaitanya Kulkarni wrote: > For now, there is no way to map verify operation to the VFS layer API. > This patch emulates verify operation by offloading it to the workqueue > and reading the data using vfs layer APIs for both buffered io and > direct io mode. What does this buy us? I'm generally not too happy about adding actualy logic to nvmet, it is supposed to mostly just pass through operations support by block device or files.