public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] nvme-pci: phison e16 has bogus namespace ids
@ 2022-07-05 17:21 Keith Busch
  2022-07-06  2:08 ` Chaitanya Kulkarni
  2022-07-06 16:10 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2022-07-05 17:21 UTC (permalink / raw)
  To: linux-nvme, hch; +Cc: Keith Busch, Chris Egolf

From: Keith Busch <kbusch@kernel.org>

Add the quirk.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216049
Reported-by: Chris Egolf <cegolf@ugholf.net>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index e7af2234e53b..193b44755662 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3465,7 +3465,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1987, 0x5012),	/* Phison E12 */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1987, 0x5016),	/* Phison E16 */
-		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1b4b, 0x1092),	/* Lexar 256 GB SSD */
 		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
-- 
2.30.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvme-pci: phison e16 has bogus namespace ids
  2022-07-05 17:21 [PATCH] nvme-pci: phison e16 has bogus namespace ids Keith Busch
@ 2022-07-06  2:08 ` Chaitanya Kulkarni
  2022-07-06 16:10 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-07-06  2:08 UTC (permalink / raw)
  To: Keith Busch
  Cc: Keith Busch, hch@lst.de, linux-nvme@lists.infradead.org,
	Chris Egolf

On 7/5/22 10:21, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Add the quirk.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216049
> Reported-by: Chris Egolf <cegolf@ugholf.net>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---

List of controllers for quirks is really getting long just
an observation, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvme-pci: phison e16 has bogus namespace ids
  2022-07-05 17:21 [PATCH] nvme-pci: phison e16 has bogus namespace ids Keith Busch
  2022-07-06  2:08 ` Chaitanya Kulkarni
@ 2022-07-06 16:10 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-07-06 16:10 UTC (permalink / raw)
  To: Keith Busch; +Cc: linux-nvme, hch, Keith Busch, Chris Egolf

Thanks,

applied to nvme-5.19.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-06 16:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-05 17:21 [PATCH] nvme-pci: phison e16 has bogus namespace ids Keith Busch
2022-07-06  2:08 ` Chaitanya Kulkarni
2022-07-06 16:10 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox