From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander <csander@purestorage.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme-tcp: use in-capsule data for I/O connect
Date: Fri, 8 Jul 2022 07:00:38 +0200 [thread overview]
Message-ID: <20220708050038.GA15655@lst.de> (raw)
In-Reply-To: <20220707211245.3989107-1-csander@purestorage.com>
On Thu, Jul 07, 2022 at 03:12:45PM -0600, Caleb Sander wrote:
> >From the NVMe/TCP spec:
> > The maximum amount of in-capsule data for Fabrics and Admin Commands
> > is 8,192 bytes ... NVMe/TCP controllers must support in-capsule data
> > for Fabrics and Admin Command Capsules
>
> Currently, command data is only sent in-capsule on the admin queue
> or I/O queues that indicate support for it.
> Send fabrics command data in-capsule for I/O queues too to avoid
> needing a separate H2CData PDU for the connect command.
While I'm fine with this change, can you please state here why this
is important? Is there a use case where it really matters? A controller
that is unhappy if this doesn't happen?
next prev parent reply other threads:[~2022-07-08 5:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 14:49 [PATCH] nvme/tcp: use in-capsule data for fabrics commands Caleb Sander
2022-07-07 6:29 ` Sagi Grimberg
2022-07-07 21:12 ` [PATCH v2] nvme-tcp: use in-capsule data for I/O connect Caleb Sander
2022-07-08 5:00 ` Christoph Hellwig [this message]
2022-07-08 15:56 ` Caleb Sander
2022-07-10 11:05 ` Sagi Grimberg
2022-07-11 19:18 ` Caleb Sander
2022-07-12 15:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708050038.GA15655@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=csander@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox