public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Kanchan Joshi <joshi.k@samsung.com>
To: hch@lst.de, sagi@grimberg.me, kbusch@kernel.org, axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, asml.silence@gmail.com,
	joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: [PATCH for-next 1/4] io_uring, nvme: rename a function
Date: Mon, 11 Jul 2022 16:31:52 +0530	[thread overview]
Message-ID: <20220711110155.649153-2-joshi.k@samsung.com> (raw)
In-Reply-To: <20220711110155.649153-1-joshi.k@samsung.com>

io_uring_cmd_complete_in_task() is bit of a misnomer. It schedules a
callback function for execution in task context. What callback does is
private to provider, and does not have to be completion. So rename it to
io_uring_cmd_execute_in_task() to allow more generic use.

Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
 drivers/nvme/host/ioctl.c | 2 +-
 include/linux/io_uring.h  | 4 ++--
 io_uring/uring_cmd.c      | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index a2e89db1cd63..9227e07f717e 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -395,7 +395,7 @@ static void nvme_uring_cmd_end_io(struct request *req, blk_status_t err)
 	pdu->req = req;
 	req->bio = bio;
 	/* this takes care of moving rest of completion-work to task context */
-	io_uring_cmd_complete_in_task(ioucmd, nvme_uring_task_cb);
+	io_uring_cmd_execute_in_task(ioucmd, nvme_uring_task_cb);
 }
 
 static int nvme_uring_cmd_io(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
diff --git a/include/linux/io_uring.h b/include/linux/io_uring.h
index 4a2f6cc5a492..54063d67506b 100644
--- a/include/linux/io_uring.h
+++ b/include/linux/io_uring.h
@@ -29,7 +29,7 @@ struct io_uring_cmd {
 
 #if defined(CONFIG_IO_URING)
 void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret, ssize_t res2);
-void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
+void io_uring_cmd_execute_in_task(struct io_uring_cmd *ioucmd,
 			void (*task_work_cb)(struct io_uring_cmd *));
 struct sock *io_uring_get_socket(struct file *file);
 void __io_uring_cancel(bool cancel_all);
@@ -59,7 +59,7 @@ static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
 		ssize_t ret2)
 {
 }
-static inline void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
+static inline void io_uring_cmd_execute_in_task(struct io_uring_cmd *ioucmd,
 			void (*task_work_cb)(struct io_uring_cmd *))
 {
 }
diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index 0a421ed51e7e..d409b99abac5 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -16,7 +16,7 @@ static void io_uring_cmd_work(struct io_kiocb *req, bool *locked)
 	ioucmd->task_work_cb(ioucmd);
 }
 
-void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
+void io_uring_cmd_execute_in_task(struct io_uring_cmd *ioucmd,
 			void (*task_work_cb)(struct io_uring_cmd *))
 {
 	struct io_kiocb *req = cmd_to_io_kiocb(ioucmd);
@@ -25,7 +25,7 @@ void io_uring_cmd_complete_in_task(struct io_uring_cmd *ioucmd,
 	req->io_task_work.func = io_uring_cmd_work;
 	io_req_task_work_add(req);
 }
-EXPORT_SYMBOL_GPL(io_uring_cmd_complete_in_task);
+EXPORT_SYMBOL_GPL(io_uring_cmd_execute_in_task);
 
 static inline void io_req_set_cqe32_extra(struct io_kiocb *req,
 					  u64 extra1, u64 extra2)
-- 
2.25.1



  reply	other threads:[~2022-07-11 11:08 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220711110753epcas5p4169b9e288d15ca35740dbb66a6f6983a@epcas5p4.samsung.com>
2022-07-11 11:01 ` [PATCH for-next 0/4] nvme-multipathing for uring-passthrough Kanchan Joshi
2022-07-11 11:01   ` Kanchan Joshi [this message]
2022-07-14 13:55     ` [PATCH for-next 1/4] io_uring, nvme: rename a function Ming Lei
2022-07-11 11:01   ` [PATCH for-next 2/4] nvme: compact nvme_uring_cmd_pdu struct Kanchan Joshi
2022-07-12  6:32     ` Christoph Hellwig
2022-07-11 11:01   ` [PATCH for-next 3/4] io_uring: grow a field in struct io_uring_cmd Kanchan Joshi
2022-07-11 17:00     ` Sagi Grimberg
2022-07-11 17:19       ` Jens Axboe
2022-07-11 17:18     ` Jens Axboe
2022-07-11 17:55       ` Sagi Grimberg
2022-07-11 18:22         ` Sagi Grimberg
2022-07-11 18:24           ` Jens Axboe
2022-07-11 18:58             ` Sagi Grimberg
2022-07-12 11:40             ` Kanchan Joshi
2022-07-14  3:40           ` Ming Lei
2022-07-14  8:19             ` Kanchan Joshi
2022-07-14 15:30               ` Daniel Wagner
2022-07-15 11:07                 ` Kanchan Joshi
2022-07-18  9:03                   ` Daniel Wagner
2022-07-11 11:01   ` [PATCH for-next 4/4] nvme-multipath: add multipathing for uring-passthrough commands Kanchan Joshi
2022-07-11 13:51     ` Sagi Grimberg
2022-07-11 15:12       ` Stefan Metzmacher
2022-07-11 16:58         ` Sagi Grimberg
2022-07-11 18:54         ` Kanchan Joshi
2022-07-11 18:37       ` Kanchan Joshi
2022-07-11 19:56         ` Sagi Grimberg
2022-07-12  4:23           ` Kanchan Joshi
2022-07-12 21:26             ` Sagi Grimberg
2022-07-13  5:37               ` Kanchan Joshi
2022-07-13  9:03                 ` Sagi Grimberg
2022-07-13 11:28                   ` Kanchan Joshi
2022-07-13 12:17                     ` Sagi Grimberg
2022-07-14 15:14                 ` Ming Lei
2022-07-14 23:05                   ` Kanchan Joshi
2022-07-15  1:35                     ` Ming Lei
2022-07-15  1:46                       ` Ming Lei
2022-07-15  4:24                         ` Kanchan Joshi
2022-07-12  6:52     ` Christoph Hellwig
2022-07-12 11:33       ` Kanchan Joshi
2022-07-12 20:13       ` Sagi Grimberg
2022-07-13  5:36         ` Christoph Hellwig
2022-07-13  8:04           ` Sagi Grimberg
2022-07-13 10:12             ` Christoph Hellwig
2022-07-13 11:00               ` Sagi Grimberg
2022-07-13 11:28                 ` Christoph Hellwig
2022-07-13 12:16                   ` Sagi Grimberg
2022-07-13 11:49                 ` Hannes Reinecke
2022-07-13 12:43                   ` Sagi Grimberg
2022-07-13 13:30                     ` Hannes Reinecke
2022-07-13 13:41                       ` Sagi Grimberg
2022-07-13 14:07                         ` Hannes Reinecke
2022-07-13 15:59                           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711110155.649153-2-joshi.k@samsung.com \
    --to=joshi.k@samsung.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=joshiiitr@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox