Re: [PATCH V2 0/6] block: add support for REQ_OP_VERIFY

Chaitanya Kulkarni
2022-07-14T15:00:55Z

On 7/13/2022 5:19 AM, Matthew Wilcox wrote:
> On Wed, Jul 13, 2022 at 12:20:13AM -0700, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> One of the responsibilities of the Operating System, along with managing
>> resources, is to provide a unified interface to the user by creating
>> hardware abstractions. In the Linux Kernel storage stack that
>> abstraction is created by implementing the generic request operations
>> such as REQ_OP_READ/REQ_OP_WRITE or REQ_OP_DISCARD/REQ_OP_WRITE_ZEROES,
>> etc that are mapped to the specific low-level hardware protocol commands
>> e.g. SCSI or NVMe.
>
> Still NAK, see previous thread for reasons. Somewhat disappointing that
> you sent a new version instead of addressing those comments first.

I've also asked you exactly what do you expect as I did not understand
your first reply.

I've added the fixes to this version based on the other comments that
I've received as I think they still needs be to reviewed.

As I can see your reply earlier today, I'll continue discussion on that
thread.

-ck