From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
Joel Granados <j.granados@samsung.com>,
kbusch@kernel.org, joshi.k@samsung.com,
linux-nvme@lists.infradead.org, gost.dev@samsung.com,
k.jensen@samsung.com
Subject: Re: [PATCH 3/5] nvme: refactor namespace probing
Date: Wed, 13 Jul 2022 12:16:55 +0200 [thread overview]
Message-ID: <20220713101655.GA27936@lst.de> (raw)
In-Reply-To: <a09f1d0d-09de-6dd6-3810-d6fd5e11f63d@grimberg.me>
On Wed, Jul 13, 2022 at 12:21:51PM +0300, Sagi Grimberg wrote:
> Maybe nvme_ns_info can have a id reference such that
> nvme_update_ns_info_block can reuse it?
I thought about it and, and it does seem doable. But it just seems
like an awful lack of abstraction, all for avoiding a single command
on some setups. True, those are the absolute majority right now, but
with more and more information going to go into the comman set
independent identify page it will become less and less so going
forward.
next prev parent reply other threads:[~2022-07-13 10:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220713054925eucas1p2f1015324abe9ccf6a665212f41d553c7@eucas1p2.samsung.com>
2022-07-13 5:49 ` enable generic interface (/dev/ngX) for unknown command sets Christoph Hellwig
2022-07-13 5:49 ` [PATCH 1/5] nvme: rename nvme_validate_or_alloc_ns to nvme_scan_ns Christoph Hellwig
2022-07-13 7:29 ` Chaitanya Kulkarni
2022-07-13 9:11 ` Sagi Grimberg
2022-07-13 10:23 ` Kanchan Joshi
2022-07-13 5:49 ` [PATCH 2/5] nvme: generalize the nvme_multi_css check in nvme_scan_ns Christoph Hellwig
2022-07-13 7:32 ` Chaitanya Kulkarni
2022-07-13 9:12 ` Sagi Grimberg
2022-07-13 10:24 ` Kanchan Joshi
2022-07-13 5:49 ` [PATCH 3/5] nvme: refactor namespace probing Christoph Hellwig
2022-07-13 9:21 ` Sagi Grimberg
2022-07-13 10:16 ` Christoph Hellwig [this message]
2022-07-13 11:29 ` Sagi Grimberg
2022-07-13 10:17 ` Kanchan Joshi
2022-07-13 11:27 ` Christoph Hellwig
2022-07-13 5:49 ` [PATCH 4/5] nvme: factor out a nvme_ns_is_readonly helper Christoph Hellwig
2022-07-13 7:55 ` Chaitanya Kulkarni
2022-07-13 9:23 ` Sagi Grimberg
2022-07-13 10:26 ` Kanchan Joshi
2022-07-13 5:49 ` [PATCH 5/5] nvme: enable generic interface (/dev/ngXnY) for unknown command sets Christoph Hellwig
2022-07-13 9:25 ` Sagi Grimberg
2022-07-13 10:19 ` Christoph Hellwig
2022-07-13 9:27 ` enable generic interface (/dev/ngX) " Javier González
2022-07-18 5:24 enable generic interface (/dev/ngX) for unknown command sets v2 Christoph Hellwig
2022-07-18 5:25 ` [PATCH 3/5] nvme: refactor namespace probing Christoph Hellwig
2022-07-19 7:08 ` Kanchan Joshi
2022-07-19 13:00 ` Joel Granados
2022-07-19 14:37 ` Christoph Hellwig
2022-07-20 8:11 ` Joel Granados
2022-07-20 8:19 ` Joel Granados
2022-07-20 9:02 ` Christoph Hellwig
2022-07-20 12:15 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713101655.GA27936@lst.de \
--to=hch@lst.de \
--cc=gost.dev@samsung.com \
--cc=j.granados@samsung.com \
--cc=joshi.k@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox