Re: [PATCH 3/5] nvme: refactor namespace probing

Sagi Grimberg
2022-07-13T09:21:59Z

> Change nvme_ns_scan to gather all information needed for generic
> namespace setup into a nvme_ns_info structure. This structure is filled
> from the Command Set Idependent Identify Namespace data structure if
> it is available or else the legacy Identify namespace structure.
>
> With that everything related to the NVM command set (and the ZNS command
> set derived from it) can be encapsulated in the nvme_update_ns_info_block
> function while keeping the rest of the namespace probing generic.
>
> The downside is that we now always issue two Identify Namespace calls for
> each probed namespace instead of usually just a single one previously.

Maybe nvme_ns_info can have a id reference such that
nvme_update_ns_info_block can reuse it?

Not that I care all that much, but it does seem redundant.