Re: [PATCH 0/1] nvme: Remove unused enum constants in nvme.h

[Joel Granados <j.granados@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

On Wed, Jun 22, 2022 at 10:48:58AM +0200, Joel Granados wrote:
> While working in include/linux/nvme.h, I noticed that there are enum
> constants that are not being used by the kernel. They are also not included
> in any UAPI directory. These variables were synced to keep up with nvme-cli
> in 48c9e85b2346 ("nvme: resync include/linux/nvme.h with nvmecli"). Since
> nvme-cli now uses libnvme which defines all the structures within itself,
> there is no need to synchronize any longer.
> 
> There have been discussions to introduce functionality into the kernel that
> use some of these variables like in
> https://lore.kernel.org/all/1558278418-5702-1-git-send-email-akinobu.mita@gmail.com/
> but to my knowledge they have not made it upstream.
> 
> This patch removes the enumerations that are not being used within the
> kernel.
> 
> Please get back to me if I have missed something and these variables are
> indeed being used.
> 
> Best
> 
> Joel Granados (1):
>   nvme: Remove unused enum constants
> 
>  include/linux/nvme.h | 32 --------------------------------
>  1 file changed, 32 deletions(-)
> 
> -- 
> 2.30.2
> 
> 

Ping. Does this make sense? Or are we keeping these around for future
use?

Best

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]