From: Joel Granados <j.granados@samsung.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, joshi.k@samsung.com,
linux-nvme@lists.infradead.org, gost.dev@samsung.com,
k.jensen@samsung.com, "Javier González" <javier.gonz@samsung.com>
Subject: Re: [PATCH 3/5] nvme: refactor namespace probing
Date: Wed, 20 Jul 2022 14:15:44 +0200 [thread overview]
Message-ID: <20220720121544.eg7lku5hxgant4ln@localhost> (raw)
In-Reply-To: <20220720090234.GB18210@lst.de>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Wed, Jul 20, 2022 at 11:02:34AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 20, 2022 at 10:19:12AM +0200, Joel Granados wrote:
> > > +struct nvme_ns_info {
> > > + struct nvme_ns_ids ids;
> > > + u32 nsid;
> > > + __le32 anagrpid;
> > > + bool is_shared;
> > > + bool is_ready;
> > > +};
> > Nitpick after looking at this for the second time:
> > Should we use tabs instead of spaces to increase readability here?
>
> Not sure why that would help.
Was unsure what the convention was, that is why I asked.
>
> > > - unsigned lbaf = nvme_lbaf_index(id->flbas);
> > > + struct nvme_id_ns *id;
> > > + unsigned lbaf;
> > Checkpatch.pl has a warning here for use of 'unsigned int' instead of
> > just 'unsigned'
>
> checkpatch is, as so often, rather misguided here.
Don't kill the messenger ;). Should we just remove the warning?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-07-20 12:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 5:24 enable generic interface (/dev/ngX) for unknown command sets v2 Christoph Hellwig
2022-07-18 5:24 ` [PATCH 1/5] nvme: rename nvme_validate_or_alloc_ns to nvme_scan_ns Christoph Hellwig
2022-07-19 13:07 ` Joel Granados
2022-07-18 5:25 ` [PATCH 2/5] nvme: generalize the nvme_multi_css check in nvme_scan_ns Christoph Hellwig
2022-07-18 5:25 ` [PATCH 3/5] nvme: refactor namespace probing Christoph Hellwig
2022-07-19 7:08 ` Kanchan Joshi
2022-07-19 13:00 ` Joel Granados
2022-07-19 14:37 ` Christoph Hellwig
2022-07-20 8:11 ` Joel Granados
2022-07-20 8:19 ` Joel Granados
2022-07-20 9:02 ` Christoph Hellwig
2022-07-20 12:15 ` Joel Granados [this message]
2022-07-18 5:25 ` [PATCH 4/5] nvme: factor out a nvme_ns_is_readonly helper Christoph Hellwig
2022-07-18 5:25 ` [PATCH 5/5] nvme: enable generic interface (/dev/ngXnY) for unknown command sets Christoph Hellwig
2022-07-21 22:14 ` enable generic interface (/dev/ngX) for unknown command sets v2 Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2022-07-13 5:49 enable generic interface (/dev/ngX) for unknown command sets Christoph Hellwig
2022-07-13 5:49 ` [PATCH 3/5] nvme: refactor namespace probing Christoph Hellwig
2022-07-13 9:21 ` Sagi Grimberg
2022-07-13 10:16 ` Christoph Hellwig
2022-07-13 11:29 ` Sagi Grimberg
2022-07-13 10:17 ` Kanchan Joshi
2022-07-13 11:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720121544.eg7lku5hxgant4ln@localhost \
--to=j.granados@samsung.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox