* [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS
@ 2022-07-20 11:37 Lukas Bulwahn
2022-07-20 11:39 ` Hannes Reinecke
2022-07-21 5:41 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2022-07-20 11:37 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
intends to select 'Support for RFC 7919 FFDHE group parameters' for using
FFDHE groups for NVMe In-Band Authentication.
It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.
Correct the select to the intended config option.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/nvme/target/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index f0c91f7686a3..79fc64035ee3 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
select CRYPTO_SHA256
select CRYPTO_SHA512
select CRYPTO_DH
- select CRYPTO_DH_GROUPS_RFC7919
+ select CRYPTO_DH_RFC7919_GROUPS
help
This enables support for NVMe over Fabrics In-band Authentication
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS
2022-07-20 11:37 [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS Lukas Bulwahn
@ 2022-07-20 11:39 ` Hannes Reinecke
2022-07-21 5:41 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2022-07-20 11:39 UTC (permalink / raw)
To: Lukas Bulwahn, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme
Cc: kernel-janitors, linux-kernel
On 7/20/22 13:37, Lukas Bulwahn wrote:
> Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
> intends to select 'Support for RFC 7919 FFDHE group parameters' for using
> FFDHE groups for NVMe In-Band Authentication.
>
> It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
> CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.
>
> Correct the select to the intended config option.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/nvme/target/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
> index f0c91f7686a3..79fc64035ee3 100644
> --- a/drivers/nvme/target/Kconfig
> +++ b/drivers/nvme/target/Kconfig
> @@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> select CRYPTO_DH
> - select CRYPTO_DH_GROUPS_RFC7919
> + select CRYPTO_DH_RFC7919_GROUPS
> help
> This enables support for NVMe over Fabrics In-band Authentication
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS
2022-07-20 11:37 [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS Lukas Bulwahn
2022-07-20 11:39 ` Hannes Reinecke
@ 2022-07-21 5:41 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-07-21 5:41 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Hannes Reinecke, Christoph Hellwig, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme, kernel-janitors, linux-kernel
Thanks,
applied to nvme-5.20.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-21 5:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-20 11:37 [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS Lukas Bulwahn
2022-07-20 11:39 ` Hannes Reinecke
2022-07-21 5:41 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox