From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Martin George <marting@netapp.com>
Subject: Re: [PATCH] nvme-auth: retry command if DNR bit is not set
Date: Thu, 28 Jul 2022 20:34:56 +0200 [thread overview]
Message-ID: <20220728183456.GA22439@lst.de> (raw)
In-Reply-To: <20220727061144.54203-1-hare@suse.de>
On Wed, Jul 27, 2022 at 08:11:44AM +0200, Hannes Reinecke wrote:
> If the cqe returns a status with the DNR bit not set we should
> retry the command; otherwise we might incur spurious failures.
If we want to start retrying passthrough commands we should do
that properly by setting a flag in the nvme_request and use the
normal retry code instead of open coding that in the callers.
prev parent reply other threads:[~2022-07-28 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 6:11 [PATCH] nvme-auth: retry command if DNR bit is not set Hannes Reinecke
2022-07-27 8:12 ` Chaitanya Kulkarni
2022-07-28 18:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728183456.GA22439@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox