From: Guenter Roeck <linux@roeck-us.net>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: linux-nvme@lists.infradead.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] nvme: hwmon: Add support for throttling temperature feature
Date: Sat, 6 Aug 2022 01:31:13 -0700 [thread overview]
Message-ID: <20220806083113.GA3986075@roeck-us.net> (raw)
In-Reply-To: <20220806054606.7280-1-ikegami.t@gmail.com>
On Sat, Aug 06, 2022 at 02:46:06PM +0900, Tokunori Ikegami wrote:
> NVMe drives support host controlled thermal management feature as optional.
> The thermal management temperature are different from the temperature threshold.
> So add functionality to set the throttling temperature values.
>
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
NACK. There are several existing limit attributes which can be used
for this purpose. I would suggest to use EMERGENCY and LCRIT attributes.
Furthermore, one can not just extend the hwmon ABI without discussion,
much less as part of a patch introducing its use. Any attribute introduced
into the ABI must benefit more than one device, and a matching
implementation in the sensors command and the lm-sensors library is
expected.
Guenter
next prev parent reply other threads:[~2022-08-06 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 5:46 [PATCH] nvme: hwmon: Add support for throttling temperature feature Tokunori Ikegami
2022-08-06 8:31 ` Guenter Roeck [this message]
2022-08-06 11:58 ` Tokunori Ikegami
2022-08-06 20:19 ` Armin Wolf
2022-08-07 15:02 ` Tokunori Ikegami
2022-08-07 6:05 ` Guenter Roeck
2022-08-07 15:06 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220806083113.GA3986075@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ikegami.t@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox