From: Jackie Liu <liu.yun@linux.dev>
To: sagi@grimberg.me
Cc: hch@lst.de, hare@suse.de, linux-nvme@lists.infradead.org,
kch@nvidia.com, liu.yun@linux.dev
Subject: [PATCH 2/2] nvme-auth: remove the redundant req->cqe->result.u16 assignment operation
Date: Fri, 12 Aug 2022 11:12:31 +0800 [thread overview]
Message-ID: <20220812031231.3386953-2-liu.yun@linux.dev> (raw)
In-Reply-To: <20220812031231.3386953-1-liu.yun@linux.dev>
From: Jackie Liu <liuyun01@kylinos.cn>
req->cqe->result.u16 has already been assigned in the previous line, no
need to do it again.
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
drivers/nvme/target/fabrics-cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
index f91a56180d3d..c1dfdfb92ebf 100644
--- a/drivers/nvme/target/fabrics-cmd.c
+++ b/drivers/nvme/target/fabrics-cmd.c
@@ -332,7 +332,6 @@ static void nvmet_execute_io_connect(struct nvmet_req *req)
req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid);
pr_debug("adding queue %d to ctrl %d.\n", qid, ctrl->cntlid);
- req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid);
if (nvmet_has_auth(ctrl))
nvmet_init_auth(ctrl, req);
--
2.25.1
next prev parent reply other threads:[~2022-08-12 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 3:12 [PATCH 1/2] nvmet-auth: clean up with done_kfree Jackie Liu
2022-08-12 3:12 ` Jackie Liu [this message]
2022-08-12 6:02 ` [PATCH 2/2] nvme-auth: remove the redundant req->cqe->result.u16 assignment operation Hannes Reinecke
2022-08-12 17:44 ` Chaitanya Kulkarni
2022-08-14 11:45 ` Sagi Grimberg
2022-08-12 6:01 ` [PATCH 1/2] nvmet-auth: clean up with done_kfree Hannes Reinecke
2022-08-12 17:43 ` Chaitanya Kulkarni
2022-08-14 11:45 ` Sagi Grimberg
2022-09-05 11:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812031231.3386953-2-liu.yun@linux.dev \
--to=liu.yun@linux.dev \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox