public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>, linux-nvme@lists.infradead.org
Cc: Yi Zhang <yi.zhang@redhat.com>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 2/2] nvme-pci: don't wait freeze during resetting
Date: Sun, 21 Aug 2022 16:47:54 +0800	[thread overview]
Message-ID: <20220821084754.340585-3-ming.lei@redhat.com> (raw)
In-Reply-To: <20220821084754.340585-1-ming.lei@redhat.com>

First it isn't necessary to call nvme_wait_freeze in nvme_reset_work().
If tagset isn't allocated, there can't be any inflight IOs; otherwise
blk_mq_update_nr_hw_queues can freeze & wait queues.

Second, since commit bdd6316094e0 ("block: Allow unfreezing of a queue
while requests are in progress"), it is fine to unfreeze queue without
draining inflight IOs.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/nvme/host/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 3a1c37f32f30..91b2903fcc24 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2910,7 +2910,6 @@ static void nvme_reset_work(struct work_struct *work)
 		nvme_free_tagset(dev);
 	} else {
 		nvme_start_queues(&dev->ctrl);
-		nvme_wait_freeze(&dev->ctrl);
 		if (!dev->ctrl.tagset)
 			nvme_pci_alloc_tag_set(dev);
 		else
-- 
2.31.1



  parent reply	other threads:[~2022-08-21  8:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21  8:47 [PATCH 0/2] nvme: make NVMe freeze API reliably Ming Lei
2022-08-21  8:47 ` [PATCH 1/2] " Ming Lei
2022-08-24 11:15   ` Hannes Reinecke
2022-08-24 14:07     ` Keith Busch
2022-08-25 10:02   ` Chao Leng
2022-09-06  4:49     ` Christoph Hellwig
2022-09-06  8:45     ` Ming Lei
2022-09-06  9:32       ` Chao Leng
2022-09-07  0:33         ` Ming Lei
2022-09-07  1:18           ` Chao Leng
2022-09-07  2:06             ` Ming Lei
2022-09-07  5:58               ` Chao Leng
2022-08-28 14:37   ` Sagi Grimberg
2022-08-21  8:47 ` Ming Lei [this message]
2022-08-25 10:05   ` [PATCH 2/2] nvme-pci: don't wait freeze during resetting Chao Leng
2022-08-25 11:34     ` Ming Lei
2022-08-25 13:42       ` Keith Busch
2022-08-25 14:15         ` Ming Lei
2022-08-26  1:27           ` Chao Leng
2022-08-28 14:37   ` Sagi Grimberg
2022-09-06  4:49   ` Christoph Hellwig
2022-08-24 11:57 ` [PATCH 0/2] nvme: make NVMe freeze API reliably Yi Zhang
2022-09-19 14:52 ` Christoph Hellwig
2022-09-20  0:51   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220821084754.340585-3-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox