* [PATCH] nvme-target: add missing goto in nvmet_setup_auth()
@ 2022-08-24 7:23 Hannes Reinecke
2022-08-25 9:06 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hannes Reinecke @ 2022-08-24 7:23 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Sagi Grimberg, Keith Busch, linux-nvme, Hannes Reinecke,
Tal Lossos
There's a goto missing in nvmet_setup_auth(), causing a kernel oops
when nvme_auth_extract_key() fails.
Reported-by: Tal Lossos <tallossos@gmail.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/target/auth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
index cf690df34775..c4113b43dbfe 100644
--- a/drivers/nvme/target/auth.c
+++ b/drivers/nvme/target/auth.c
@@ -196,6 +196,7 @@ int nvmet_setup_auth(struct nvmet_ctrl *ctrl)
if (IS_ERR(ctrl->ctrl_key)) {
ret = PTR_ERR(ctrl->ctrl_key);
ctrl->ctrl_key = NULL;
+ goto out_free_hash;
}
pr_debug("%s: using ctrl hash %s key %*ph\n", __func__,
ctrl->ctrl_key->hash > 0 ?
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-target: add missing goto in nvmet_setup_auth()
2022-08-24 7:23 [PATCH] nvme-target: add missing goto in nvmet_setup_auth() Hannes Reinecke
@ 2022-08-25 9:06 ` Chaitanya Kulkarni
2022-08-28 14:58 ` Sagi Grimberg
2022-08-31 4:59 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2022-08-25 9:06 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig
Cc: Sagi Grimberg, Keith Busch, linux-nvme@lists.infradead.org,
Tal Lossos
On 8/24/22 00:23, Hannes Reinecke wrote:
> There's a goto missing in nvmet_setup_auth(), causing a kernel oops
> when nvme_auth_extract_key() fails.
>
> Reported-by: Tal Lossos <tallossos@gmail.com>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-target: add missing goto in nvmet_setup_auth()
2022-08-24 7:23 [PATCH] nvme-target: add missing goto in nvmet_setup_auth() Hannes Reinecke
2022-08-25 9:06 ` Chaitanya Kulkarni
@ 2022-08-28 14:58 ` Sagi Grimberg
2022-08-31 4:59 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2022-08-28 14:58 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Keith Busch, linux-nvme, Tal Lossos
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-target: add missing goto in nvmet_setup_auth()
2022-08-24 7:23 [PATCH] nvme-target: add missing goto in nvmet_setup_auth() Hannes Reinecke
2022-08-25 9:06 ` Chaitanya Kulkarni
2022-08-28 14:58 ` Sagi Grimberg
@ 2022-08-31 4:59 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-08-31 4:59 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme,
Tal Lossos
Thanks,
applied to nvme-6.0.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-31 4:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 7:23 [PATCH] nvme-target: add missing goto in nvmet_setup_auth() Hannes Reinecke
2022-08-25 9:06 ` Chaitanya Kulkarni
2022-08-28 14:58 ` Sagi Grimberg
2022-08-31 4:59 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox