public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv2 0/2] nvme: honor DNR status for authentication
Date: Tue, 30 Aug 2022 14:49:23 +0200	[thread overview]
Message-ID: <20220830124925.40711-1-hare@suse.de> (raw)

Hi all,

when sending authentication commands we should be checking the DNR bit
in the cqe status to figure out if a command should be retried.
So the first patch will evaluate the DNR bit during _nvme_submit_sync_cmd()
and initiate a retry, and the second patch will set the DNR bit in
the nvme authentication code such that we don't attempt to retry the
'connect' operation.
I have opened pull request #100 for blktests to validate this behaviour.

As usual, comments and reviews are welcome.

Hannes Reinecke (2):
  nvme-auth: retry command if DNR bit is not set
  nvme-auth: set the DNR bit if authentication failed

 drivers/nvme/host/auth.c    | 22 +++++++++++-----------
 drivers/nvme/host/core.c    | 20 ++++++++++++++++++--
 drivers/nvme/host/fabrics.c |  4 ++--
 include/linux/blk-mq.h      |  2 ++
 4 files changed, 33 insertions(+), 15 deletions(-)

-- 
2.35.3



             reply	other threads:[~2022-08-30 12:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 12:49 Hannes Reinecke [this message]
2022-08-30 12:49 ` [PATCH 1/2] nvme-auth: retry command if DNR bit is not set Hannes Reinecke
2022-09-05 12:05   ` Sagi Grimberg
2022-09-06 14:16     ` Hannes Reinecke
2022-09-07  6:44       ` Christoph Hellwig
2022-08-30 12:49 ` [PATCH 2/2] nvme-auth: set the DNR bit if authentication failed Hannes Reinecke
2022-09-05 11:52   ` Sagi Grimberg
2022-09-07  6:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220830124925.40711-1-hare@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox