Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chao Leng <lengchao@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
	kbusch@kernel.org
Subject: Re: [PATCH] nvme: add DIX support for nvme-rdma
Date: Mon, 5 Sep 2022 08:37:59 +0200	[thread overview]
Message-ID: <20220905063759.GB2092@lst.de> (raw)
In-Reply-To: <289da5df-e988-f0a9-95cd-2c437327a043@huawei.com>

On Tue, Aug 30, 2022 at 08:21:29PM +0800, Chao Leng wrote:
> Checksum just be used between host_buff -> host HBA, and the time
> is very short. If hardware support this, it is useful for reducing
> CPU utilization and data security can be acceptable like SCSI.

No, that is not how _end to and_ data protection works.

And as said before, the IP checksums are not actually specified in NVMe
to start with.


  reply	other threads:[~2022-09-05  6:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  8:12 [PATCH] nvme: add DIX support for nvme-rdma Chao Leng
2022-08-29  9:02 ` Sagi Grimberg
2022-08-29 10:43 ` Max Gurtovoy
2022-08-29 13:16   ` Chao Leng
2022-08-29 14:56     ` Max Gurtovoy
2022-08-29 15:10       ` Keith Busch
2022-08-29 23:47         ` Max Gurtovoy
2022-08-30 12:18         ` Chao Leng
2022-08-30 14:49           ` Keith Busch
2022-08-30  2:38       ` Martin K. Petersen
2022-08-30 12:21         ` Chao Leng
2022-09-05  6:37           ` Christoph Hellwig [this message]
2022-09-06  2:13             ` Chao Leng
2022-09-06  6:59               ` Christoph Hellwig
2022-09-06  9:34                 ` Max Gurtovoy
2022-09-06  9:35                   ` Christoph Hellwig
2022-09-06 10:05                     ` Max Gurtovoy
2022-09-06 10:13                 ` Chao Leng
2022-08-30 12:15       ` Chao Leng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220905063759.GB2092@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=lengchao@huawei.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox