From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB50FC6FA83 for ; Mon, 5 Sep 2022 17:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6t4MbpJQJStzKZCv+OMTP4pypmv5BkHcUxpFt6TDwXY=; b=zdeHfP3isO0SreRw+NEzztYimy StA+rbQnCaDBCDrcH5MM1EfwhLva7lOvlqOJgavhydxWfQw25w5xxg92azmeccaEJ9pnQkiwEUlV0 x/gIL1fLrPdfAy+cyLXTylpEFPJVYnlIzvl2XMRxPgF3gdhN632U22PzF0O8YmNWF1zX+rXkbh0WP rEczhkXmVTtDI6Nxf0VgyDO3wV5ZKJnVIB4Gl7zMaNLi86hvPdKy2cwccwzg52ID0yiqSTBbwRdjP yblXWp7JXiB2f1Dyvx7FnRdAC3ZBD63ZadCHgfi9IRyuA/VmjGxj7gnNaWRuPyZOak7xjKhZeEay9 ExMarKMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVFZi-007GqF-BV; Mon, 05 Sep 2022 17:07:54 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVDAu-004VmF-Ht for linux-nvme@lists.infradead.org; Mon, 05 Sep 2022 14:34:31 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3D51A68AFE; Mon, 5 Sep 2022 16:34:05 +0200 (CEST) Date: Mon, 5 Sep 2022 16:34:05 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Greg Kroah-Hartman , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Stephen Bates Subject: Re: [PATCH v9 3/8] block: add check when merging zone device pages Message-ID: <20220905143405.GB5813@lst.de> References: <20220825152425.6296-1-logang@deltatee.com> <20220825152425.6296-4-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825152425.6296-4-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_073426_723960_CD415FB5 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 09:24:20AM -0600, Logan Gunthorpe wrote: > Consecutive zone device pages should not be merged into the same sgl > or bvec segment with other types of pages or if they belong to different > pgmaps. Otherwise getting the pgmap of a given segment is not possible > without scanning the entire segment. This helper returns true either if > both pages are not zone device pages or both pages are zone device > pages with the same pgmap. > > Add a helper to determine if zone device pages are mergeable and use > this helper in page_is_mergeable(). > > Signed-off-by: Logan Gunthorpe Looks good: Reviewed-by: Christoph Hellwig