From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: John Meneghini <jmeneghi@redhat.com>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-tcp: delay error recovery after link drop
Date: Wed, 7 Sep 2022 10:41:17 +0200 [thread overview]
Message-ID: <20220907084117.GA29779@lst.de> (raw)
In-Reply-To: <2a5f39bd-c545-1224-12af-ce16feab4b5a@grimberg.me>
On Wed, Sep 07, 2022 at 10:57:20AM +0300, Sagi Grimberg wrote:
>> I'm not sure the NVMe/TCP host stack obeys this rule.
>>
>> The problem is, when the host fails to follow this rule, some NVMe/TCP
>> controllers are found to corrupt data during cable pull tests.
>
> The delay needs to come explicitly from the controller, not guessed
> blindly by the host.
No timeout can work properly. What we need is a proper handshake.
prev parent reply other threads:[~2022-09-07 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:27 [PATCH] nvme-tcp: delay error recovery after link drop Hannes Reinecke
2022-07-14 14:42 ` Sagi Grimberg
2022-07-14 15:15 ` Hannes Reinecke
2022-07-14 16:07 ` Sagi Grimberg
2022-09-06 17:30 ` John Meneghini
2022-09-07 7:57 ` Sagi Grimberg
2022-09-07 8:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907084117.GA29779@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox