From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, gost.dev@samsung.com,
linux-scsi@vger.kernel.org, Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH for-next v11 04/13] nvme: refactor nvme_alloc_request
Date: Thu, 29 Sep 2022 15:25:38 +0200 [thread overview]
Message-ID: <20220929132538.GA27768@lst.de> (raw)
In-Reply-To: <20220929120632.64749-5-anuj20.g@samsung.com>
On Thu, Sep 29, 2022 at 05:36:23PM +0530, Anuj Gupta wrote:
> From: Kanchan Joshi <joshi.k@samsung.com>
>
> nvme_alloc_request expects a large number of parameters.
> Split this out into two functions to reduce number of parameters.
> First one retains the name nvme_alloc_request, while second one is
> named nvme_map_user_request.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-09-29 13:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220929121630epcas5p3e1ed2c5251276d557f8f921e8186620f@epcas5p3.samsung.com>
2022-09-29 12:06 ` [PATCH for-next v11 00/13] Fixed-buffer for uring-cmd/passthru Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 01/13] io_uring: add io_uring_cmd_import_fixed Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 02/13] io_uring: introduce fixed buffer support for io_uring_cmd Anuj Gupta
2022-09-30 1:26 ` Jens Axboe
2022-09-29 12:06 ` [PATCH for-next v11 03/13] nvme: refactor nvme_add_user_metadata Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 04/13] nvme: refactor nvme_alloc_request Anuj Gupta
2022-09-29 13:25 ` Christoph Hellwig [this message]
2022-09-29 19:48 ` kernel test robot
2022-09-29 12:06 ` [PATCH for-next v11 05/13] block: rename bio_map_put to blk_mq_map_bio_put Anuj Gupta
2022-09-29 13:25 ` Christoph Hellwig
2022-09-29 12:06 ` [PATCH for-next v11 06/13] block: factor out blk_rq_map_bio_alloc helper Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 07/13] block: add blk_rq_map_user_bvec Anuj Gupta
2022-09-29 13:26 ` Christoph Hellwig
2022-09-29 12:06 ` [PATCH for-next v11 08/13] block: extend functionality to map bvec iterator Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 09/13] nvme: pass ubuffer as an integer Anuj Gupta
2022-09-29 13:27 ` Christoph Hellwig
2022-09-29 12:06 ` [PATCH for-next v11 10/13] nvme: wire up fixed buffer support for nvme passthrough Anuj Gupta
2022-09-29 12:06 ` [PATCH for-next v11 11/13] block: add blk_rq_map_user_io Anuj Gupta
2022-09-29 13:28 ` Christoph Hellwig
2022-09-30 4:15 ` kernel test robot
2022-09-29 12:06 ` [PATCH for-next v11 12/13] scsi: Use blk_rq_map_user_io helper Anuj Gupta
2022-09-29 13:28 ` Christoph Hellwig
2022-09-29 12:06 ` [PATCH for-next v11 13/13] nvme: " Anuj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929132538.GA27768@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox