From: Joel Granados <j.granados@samsung.com>
To: Keith Busch <kbusch@kernel.org>
Cc: <hch@lst.de>, <sagi@grimberg.me>,
<linux-nvme@lists.infradead.org>, <javier.gonz@samsung.com>,
<gost.dev@samsung.com>, <joshi.k@samsung.com>
Subject: Re: [RFC 0/2] nvme : Add whitelist for admin commands in passthru
Date: Tue, 11 Oct 2022 08:50:02 +0200 [thread overview]
Message-ID: <20221011065002.4tplqzxejbkiyxvk@localhost> (raw)
In-Reply-To: <Y0BvbFxg5in8H31o@kbusch-mbp.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
Hey Keith
Thx for the initial feedback.
On Fri, Oct 07, 2022 at 12:26:52PM -0600, Keith Busch wrote:
> Just fyi, Documentation/process/coding-style.rst recommends against
> using the term "whitelist" and has alternative suggestions.
I was not aware of this. Maybe allowlist is what fits more in this case.
>
> I'll try to make time to provide more techincal feedback on the patch in
> the next week, though I am travelling for much of it, so no promises.
looking forward to it
Best
Joel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-10-11 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221007132636eucas1p207b5f2e42f831bd7cb4c15f6e6ae4758@eucas1p2.samsung.com>
2022-10-07 13:22 ` [RFC 0/2] nvme : Add whitelist for admin commands in passthru Joel Granados
2022-10-07 13:22 ` [RFC 1/2] nvme : Add dynamic whitelisting for passthru Joel Granados
2022-10-07 13:22 ` [RFC 2/2] nvme : Add ioctls for passthru admin whitelisting Joel Granados
2022-10-07 18:26 ` [RFC 0/2] nvme : Add whitelist for admin commands in passthru Keith Busch
2022-10-11 6:50 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011065002.4tplqzxejbkiyxvk@localhost \
--to=j.granados@samsung.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox