From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Pankaj Raghav <p.raghav@samsung.com>,
Daniel Wagner <dwagner@suse.de>,
Alan Adamson <alan.adamson@oracle.com>,
gost.dev@samsung.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: ignore starting sector while error logging for passthrough requests
Date: Tue, 18 Oct 2022 17:26:03 +0200 [thread overview]
Message-ID: <20221018152603.GB23173@lst.de> (raw)
In-Reply-To: <Y07E+bH0E2s7xKWN@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Oct 18, 2022 at 09:23:37AM -0600, Keith Busch wrote:
> What's the preferred opt-in mechanism? If we want to do it per-command,
> we have an unsused 'flags' field in the ioctl structures that we can
> start defining options for these kinds of things. If we don't want that
> level of fine grained control, we could set it at the controller or
> module level with a new sysfs file, though I'm not sure this warrants
> creating new exports there.
The flags field is what I had in mind. There's also another thing
on the plate as some folks really want to opt into kernel error
handling for passthrough commands, and that seems to be the only
way to do it.
next prev parent reply other threads:[~2022-10-18 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221006091054eucas1p1e4113b6dfd108907c2cd5ba7127a3f92@eucas1p1.samsung.com>
2022-10-06 9:10 ` [PATCH] nvme: ignore starting sector while error logging for passthrough requests Pankaj Raghav
2022-10-18 13:48 ` Pankaj Raghav
2022-10-18 14:45 ` Christoph Hellwig
2022-10-18 15:23 ` Keith Busch
2022-10-18 15:26 ` Christoph Hellwig [this message]
2022-10-18 16:35 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018152603.GB23173@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=dwagner@suse.de \
--cc=gost.dev@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox