Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	sagi@grimberg.me, fancer.lancer@gmail.com, linux@roeck-us.net,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-hwmon: don't return errors from nvme_hwmon_init
Date: Tue, 18 Oct 2022 17:31:32 +0200	[thread overview]
Message-ID: <20221018153132.GC23173@lst.de> (raw)
In-Reply-To: <Y07FoBKCrJibFOY5@kbusch-mbp.dhcp.thefacebook.com>

On Tue, Oct 18, 2022 at 09:26:24AM -0600, Keith Busch wrote:
> Yep, this looks fine. You'll just need to initialize 'int err = 0;' at
> the beginning.

Grr, stupid lack of uninitialized variable tracking in gcc..


  reply	other threads:[~2022-10-18 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 14:58 [PATCH] nvme-hwmon: don't return errors from nvme_hwmon_init Christoph Hellwig
2022-10-18 15:14 ` Serge Semin
2022-10-18 15:16   ` Christoph Hellwig
2022-10-18 15:21     ` Serge Semin
2022-10-18 15:23       ` Christoph Hellwig
2022-10-18 15:25         ` Serge Semin
2022-10-18 15:15 ` Keith Busch
2022-10-18 15:23   ` Christoph Hellwig
2022-10-18 15:26     ` Keith Busch
2022-10-18 15:31       ` Christoph Hellwig [this message]
2022-10-18 15:31       ` Serge Semin
2022-10-18 15:38         ` Christoph Hellwig
2022-10-18 15:44           ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018153132.GC23173@lst.de \
    --to=hch@lst.de \
    --cc=fancer.lancer@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox