From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
kbusch@kernel.org, fancer.lancer@gmail.com, linux@roeck-us.net,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme-hwmon: consistently ignore errors from nvme_hwmon_init
Date: Wed, 19 Oct 2022 12:41:58 +0200 [thread overview]
Message-ID: <20221019104158.GA25515@lst.de> (raw)
In-Reply-To: <3ba99d83-e8ac-8aa1-4ae6-28a99f9417be@grimberg.me>
On Wed, Oct 19, 2022 at 12:39:08PM +0300, Sagi Grimberg wrote:
>
>> An NVMe controller works perfectly fine even when the hwmon
>> initialization fails. Stop returning errors that do not come from a
>> controller reset from nvme_hwmon_init to handle this case consistently.
>
> Maybe I'm missing something, but nvme_hwmon_init is not called
> from the reset flow, only in the first init, I don't understand
> how the commit msg follows the code.
If the controller is reset during initialization we'll get EINTR
here.
prev parent reply other threads:[~2022-10-19 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:37 [PATCH v2] nvme-hwmon: consistently ignore errors from nvme_hwmon_init Christoph Hellwig
2022-10-19 8:49 ` Guenter Roeck
2022-10-19 9:04 ` Serge Semin
2022-10-19 9:39 ` Sagi Grimberg
2022-10-19 10:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019104158.GA25515@lst.de \
--to=hch@lst.de \
--cc=fancer.lancer@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox