From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7447BC433FE for ; Fri, 21 Oct 2022 13:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2pJHuxWr8reZGf9ID3L61JtaeW8RytXF9llgit766o0=; b=e/RMTyxDHVDNC8n7SV57z9Xfdh oSPfI/iuIA1Ln/ZeEW9JD76OTtOSd9YgbYhp3MiLJ5E6YhKmbcidRomqe4nbVIl9MkykHJ8ZN+gpA QN4yOXAsCJnZ1nVr+0oBJEVDoLoVjGiyAbRc4HhRju0TYxc+kad+DbCt4HNvWJKa/VH1Bf3GmmvLy T02Yajf29XrZbm0ungNEy6uzVa4kaga//abxBQMh1Bxc86XJeSOZ7OcoaD6OmePvqkFkI1lTtpcAd DhSS3Zx/rP7u1cwXHwmyEYUcE1HI+An+j0RxwRfzDtdFdOxi9FVtQrdWVPv8wwDGh2FZvslEmkOLk ar6FB3MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olrqU-007pyV-03; Fri, 21 Oct 2022 13:13:54 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olrqR-007pxn-55 for linux-nvme@lists.infradead.org; Fri, 21 Oct 2022 13:13:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A776168B05; Fri, 21 Oct 2022 15:13:47 +0200 (CEST) Date: Fri, 21 Oct 2022 15:13:47 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Chao Leng , Ming Lei , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCH 1/8] block: set the disk capacity to 0 in blk_mark_disk_dead Message-ID: <20221021131347.GB21741@lst.de> References: <20221020105608.1581940-1-hch@lst.de> <20221020105608.1581940-2-hch@lst.de> <3aebc5d7-874d-ddeb-7383-79826e98fd9d@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3aebc5d7-874d-ddeb-7383-79826e98fd9d@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_061351_352213_4DBBC322 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 08:49:30AM +0200, Hannes Reinecke wrote: > I'm ever so slightly concerned about not sending the uevent anymore; MD for > one relies on that event to figure out if a device is down. Hmm, where? I actually just had customer reports about md not noticing nvme devices going down properly and thus looking into in-kernel delivery of notifications.. > And I'm also relatively sure that testing with MD on Xen had been > relatively few. > What do we lose by using the 'notify' version instead? Mostly that we get incorrect resize events to userspace, but maybe because nvme is more common that might still be better overall.