From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02BD7C4332F for ; Fri, 21 Oct 2022 13:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aeqyAXbBrGEGFCOoCZm6pO7++XA0ZOjFPZ7FdGMxEHg=; b=zzDxKW63jeq/BdKst08EUUquOa ZofobINKggkzALh+evvOpL55NPcI4Abb3jEE7Wbc86G7R1cJt1ZRxq8OVlPbJVFPr0PDB/JN55iRY Te3cLGYjxEDdaAy5Vw6GTMFc5011B+demEzhxWYBh6imK2MGju4Ca0nxnyGQgUPn45RiVI5TIjI2I WhZuF6lKh6Q/Zur4bvdmYymG59IIUielubMAcjwKLtTMm3u0XwTzyw0Q1LRqZhFD9kxXyInmatCy3 sNGyoEttJWAaidEZsLH8ISRE51BzumB6tnQnjH2CGa00mp4gBN18p3BHvrdaFVv4gP6Thq9egNX2b jMCSTn8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olrzi-007ulq-Md; Fri, 21 Oct 2022 13:23:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olrzd-007ugw-RQ for linux-nvme@lists.infradead.org; Fri, 21 Oct 2022 13:23:23 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 191AD68B05; Fri, 21 Oct 2022 15:23:19 +0200 (CEST) Date: Fri, 21 Oct 2022 15:23:18 +0200 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Chao Leng , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: Re: [PATCH 4/8] blk-mq: pass a tagset to blk_mq_wait_quiesce_done Message-ID: <20221021132318.GD22327@lst.de> References: <20221020105608.1581940-1-hch@lst.de> <20221020105608.1581940-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_062322_068806_99F5C334 X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 09:46:33AM +0800, Ming Lei wrote: > The change is fine, but the interface could confuse people, it > looks like it is waiting for whole tagset quiesced, but it needs > to mark all request queues as quiesced first, otherwise it is just > wait for one specific queue's quiesce. > > So suggest to document such thing. Yes, that's probably a good idea. Still better would be to make this API purely internal, as the pure wait callers in NVMe and SCSI are a bit sketchy.