Re: [PATCH v11 6/9] block: set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages()

Logan Gunthorpe
2022-10-25T15:37:42Z

On 2022-10-24 19:23, Chaitanya Kulkarni wrote:
> /*
>> * Each segment in the iov is required to be a block size multiple.
>> * However, we may not be able to get the entire segment if it spans
>> @@ -1217,8 +1221,9 @@ static int __bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
>> * result to ensure the bio's total size is correct. The remainder of
>> * the iov data will be picked up in the next bio iteration.
>> */
>> - size = iov_iter_get_pages2(iter, pages, UINT_MAX - bio->bi_iter.bi_size,
>> - nr_pages, &offset);
>> + size = iov_iter_get_pages(iter, pages,
>> + UINT_MAX - bio->bi_iter.bi_size,
>> + nr_pages, &offset, gup_flags);
>
> nit, 3rd param in above call fits on the first line ? plz check :-
>
> iov_iter_get_pages(iter, pages, UINT_MAX - bio->bi_iter.bi_size,
> nr_pages, &offset, gup_flags);

Oh, yup, this just fits. I'll queue up the fix for if I send v12.

Logan