RE: [PATCH v11 1/9] mm: allow multiple error returns in try_grab_page()

Dan Williams
2022-10-24T16:38:08Z

Logan Gunthorpe wrote:
> In order to add checks for P2PDMA memory into try_grab_page(), expand
> the error return from a bool to an int/error code. Update all the
> callsites handle change in usage.
>
> Also remove the WARN_ON_ONCE() call at the callsites seeing there
> already is a WARN_ON_ONCE() inside the function if it fails.

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>